-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pixi
to replace our bash scripts and many of the Dockerfile layers
#3717
Labels
Milestone
Comments
jleibs
added
enhancement
New feature or request
🧑💻 dev experience
developer experience (excluding CI)
labels
Oct 5, 2023
3 tasks
emilk
added a commit
that referenced
this issue
Oct 16, 2023
### What * Part of #3717 Add a proof-of-concept `pixi.toml` file for the project. This is like Just but also takes care of dependency management for us. No need to run `setup_dev.sh` or `pip install -r scripts/requirements-dev.txt`. This even manages the installation of `arrow-cpp` for us. Just: ``` cargo install pixi ``` Then have fun: ``` pixi run codegen pixi run py-test pixi run cpp-test ``` Verified this works in a clean Ubuntu-20.04 docker container. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3707) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3707) - [Docs preview](https://rerun.io/preview/071e0d4c0cff28c2262b966d985cf0f68ad9f456/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/071e0d4c0cff28c2262b966d985cf0f68ad9f456/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> Co-authored-by: Andreas Reich <r_andreas2@web.de>
4 tasks
Vaguely relevant issue for me: |
We should probably keep our |
4 tasks
emilk
changed the title
Use
Use Nov 6, 2023
pixi
to replace just
and many of the Dockerfile layerspixi
to replace our bash scripts and many of the Dockerfile layers
5 tasks
Wumpf
added a commit
that referenced
this issue
Mar 18, 2024
### What Almost everything has been taken over by `pixi` by now and these outdated / partially broken scripts keep confusing new-comers to the repo, so at this point they're clearly doing more bad than good. * Fixes #5545 * Fixes #4170 * There's still some stuff that should be moved to pixi but that's better covered by #3717 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5552/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5552/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5552/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5552) - [Docs preview](https://rerun.io/preview/8da4ef3b503b5459274c73ea40bc0926b61dbae9/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/8da4ef3b503b5459274c73ea40bc0926b61dbae9/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Closed
5 tasks
Wumpf
added a commit
that referenced
this issue
Apr 11, 2024
### What Part of * #3717 After this PR, the only .sh files in the repo are `ci_docker/publish.sh` and `pre-push.sh`. The former is hopefully going away together with the docker, the later can stay. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5922?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5922?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5922) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
the only thing we didn't do is to publish rerun on pixi itself, but otherwise we ticked all the boxes now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pixi
to run codegen in a portable way #3707 seems very compellingPixi should be able to replace all of our current just commands while bringing the added benefit of running things in an environment with managed dependencies. For example, this gives us access to our code-gen dependencies, the
arrow-cpp
we need for building rerun-cpp, etc.This lets us replace all of the commands in
just
with versions that handle the dep installation first.This also lets us collapse many of the layers of our Dockerfile into a single
pixi install
invocation.TODO
venv
with pixialias
section in.cargo/config.toml
withjust
commands wrappingpixi
#4171scripts/requirements-dev.txt
etcsetup*.sh
files with pixi #4170.sh
scripts, if possible (https://prefix.dev/docs/pixi/advanced/advanced_tasks)The text was updated successfully, but these errors were encountered: