Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D images showing up in 3D space views again #4696

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Fix 2D images showing up in 3D space views again #4696

merged 6 commits into from
Jan 5, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 5, 2024 •
edited by github-actions bot
Loading

What

Before: cargo rerun ./examples/assets would show 2D images since the new filter system was actually not fed correctly with VisualizableFilterContext3D

image

Furthermore, we now also mark all 3D objects in 2D space views that don't have their origin at the pinhole as non-visualizable

Does NOT fix

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 5, 2024
@Wumpf Wumpf marked this pull request as draft January 5, 2024 13:58
@Wumpf Wumpf requested a review from jleibs January 5, 2024 14:23
@Wumpf Wumpf marked this pull request as ready for review January 5, 2024 14:23
@Wumpf Wumpf added this to the 0.12 milestone Jan 5, 2024
jleibs
jleibs approved these changes Jan 5, 2024
View reviewed changes
crates/re_space_view_spatial/src/space_view_2d.rs Outdated Show resolved Hide resolved
crates/re_space_view_spatial/src/visualizers/mod.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit ffa74a4 into main Jan 5, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/heuristic-fixes branch January 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @jleibs