Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing 3D objects in 2D space views without pinhole camera at root #4701

Closed
wants to merge 1 commit into from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 5, 2024

What

With the new system for filtering applicable entitites this is actually super easy!
I believe we didn't do this filter before at all, so likely this goes beyond fixing a regression.

DRAFT:
Confirm this. Only reproed on the Ci's web build for me!
Doesn't actually work. The problem here is that we try to display something that is under a pinhole inside a 2D spaceview. Almost feels like we want the full space partition here...

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 5, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Jan 5, 2024

@jleibs and me decided to combine with its parent pr

@Wumpf Wumpf closed this Jan 5, 2024
@Wumpf Wumpf deleted the andreas/heuristic-fixes2 branch January 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant