Fix showing 3D objects in 2D space views without pinhole camera at root #4701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With the new system for filtering applicable entitites this is actually super easy!
I believe we didn't do this filter before at all, so likely this goes beyond fixing a regression.
DRAFT:
Confirm this. Only reproed on the Ci's web build for me!Doesn't actually work. The problem here is that we try to display something that is under a pinhole inside a 2D spaceview. Almost feels like we want the full space partition here...
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io