Make including Core optional

Author: cknitt

index.mjs

@@ -16,17 +16,18 @@ const templates = [
   {
     value: "rescript-template-vite",
     label: "Vite",
-    hint: "Opinionated boilerplate for Vite, Tailwind and ReScript",
-  },
-  {
-    value: "rescript-template-nextjs",
-    label: "Next.js",
-    hint: "Opinionated boilerplate for Next.js, Tailwind and ReScript",
+    hint: "ReScript 10.1, JSX4, Vite, Tailwind CSS",
   },
   {
     value: "rescript-template-basic",
     label: "Basic",
-    hint: "Command line hello world app",
+    hint: "ReScript 10.1, command line hello world app",
+  },
+  {
+    value: "rescript-template-nextjs",
+    label: "Next.js",
+    hint: "ReScript 9.1, Next.js, Tailwind CSS",
+    incompatibleWithCore: true,
   },
 ];
 
@@ -54,15 +55,31 @@ function validateProjectName(projectName) {
   }
 }
 
-async function replaceLineInFile(filename, search, replace) {
+async function updateFile(filename, updateContents) {
   const contents = await fs.promises.readFile(filename, "utf8");
-  const replaced = contents.replace(search, replace);
-  await fs.promises.writeFile(filename, replaced, "utf8");
+  const updated = updateContents(contents);
+  await fs.promises.writeFile(filename, updated, "utf8");
 }
 
-async function setProjectName(templateName, projectName) {
-  await replaceLineInFile("package.json", `"name": "${templateName}"`, `"name": "${projectName}"`);
-  await replaceLineInFile("bsconfig.json", `"name": "${templateName}"`, `"name": "${projectName}"`);
+async function updatePackageJson(projectName) {
+  await updateFile("package.json", contents =>
+    contents.replace(/"name": "rescript-template-.*"/, `"name": "${projectName}"`)
+  );
+}
+
+async function updateBsconfigJson(projectName, withCore) {
+  await updateFile("bsconfig.json", contents => {
+    const config = JSON.parse(contents);
+
+    config["name"] = projectName;
+
+    if (withCore) {
+      config["bs-dependencies"] = [...(config["bs-dependencies"] || []), "@rescript/core"];
+      config["bsc-flags"] = [...(config["bsc-flags"] || []), "-open RescriptCore"];
+    }
+
+    return JSON.stringify(config, null, 2);
+  });
 }
 
 function getVersion() {
@@ -90,15 +107,14 @@ async function main() {
   });
   checkCancel(templateName);
 
-  const shouldContinue = await p.confirm({
-    message: `Your new ReScript project ${c.cyan(projectName)} will now be created. Continue?`,
-  });
-  checkCancel(shouldContinue);
+  const incompatibleWithCore = templates.find(t => t.value === templateName).incompatibleWithCore;
 
-  if (!shouldContinue) {
-    p.outro("No project created.");
-    process.exit(0);
-  }
+  const withCore =
+    !incompatibleWithCore &&
+    (await p.confirm({
+      message: "Add the new @rescript/core standard libary?",
+    }));
+  checkCancel(withCore);
 
   const templatePath = path.join(__dirname, "templates", templateName);
   const projectPath = path.join(process.cwd(), projectName);
@@ -110,8 +126,15 @@ async function main() {
     await fs.promises.cp(templatePath, projectPath, { recursive: true });
     process.chdir(projectPath);
 
-    await setProjectName(templateName, projectName);
-    await promisify(exec)("npm install");
+    await updatePackageJson(projectName);
+    await updateBsconfigJson(projectName, withCore);
+
+    if (withCore) {
+      await promisify(exec)("npm add @rescript/core");
+    } else {
+      await promisify(exec)("npm install");
+    }
+
     await promisify(exec)("git init");
     s.stop("Project created.");
 

templates/rescript-template-basic/bsconfig.json

@@ -9,6 +9,5 @@
     "in-source": true
   },
   "suffix": ".bs.js",
-  "bs-dependencies": ["@rescript/core"],
-  "bsc-flags": ["-open RescriptCore"]
+  "bs-dependencies": []
 }

templates/rescript-template-basic/package.json

@@ -12,7 +12,6 @@
   "author": "",
   "license": "MIT",
   "dependencies": {
-    "@rescript/core": "^0.1.0",
     "rescript": "^10.1.2"
   }
 }

templates/rescript-template-basic/src/Demo.res

@@ -1 +1 @@
-Console.log("Hello, World!")
+Js.log("Hello, World!")

templates/rescript-template-vite/README.md

@@ -2,7 +2,7 @@
 
 This is a Vite-based template with following setup:
 
-- [ReScript](https://rescript-lang.org) 10.1 with JSX 4 automatic mode and the new [`@rescript/core`](https://github.com/rescript-association/rescript-core) standard library
+- [ReScript](https://rescript-lang.org) 10.1 with @rescript/react and JSX 4 automatic mode
 - ES6 modules (ReScript code compiled to `.bs.mjs` files)
 - Vite 4 with React Plugin (Fast Refresh)
 - Tailwind 3

templates/rescript-template-vite/bsconfig.json

@@ -13,8 +13,7 @@
     }
   ],
   "suffix": ".bs.mjs",
-  "bs-dependencies": ["@rescript/core", "@rescript/react"],
-  "bsc-flags": ["-open RescriptCore"],
+  "bs-dependencies": ["@rescript/react"],
   "jsx": {
     "version": 4,
     "mode": "automatic"

templates/rescript-template-vite/package-lock.json

@@ -12,7 +12,6 @@
     "preview": "vite preview"
   },
   "dependencies": {
-    "@rescript/core": "^0.1.0",
     "@rescript/react": "^0.11.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",

templates/rescript-template-vite/package.json

@@ -9,7 +9,7 @@ let make = () => {
     </p>
     <h2 className="text-2xl font-semibold mt-5"> {React.string("Fast Refresh Test")} </h2>
     <Button onClick={_ => setCount(count => count + 1)}>
-      {React.string(`count is ${count->Int.toString}`)}
+      {React.string(`count is ${count->string_of_int}`)}
     </Button>
     <p>
       {React.string("Edit ")}