Skip to content

Conversation

danwetherald
Copy link
Contributor

Fix typo in docs for toLocaleTimeString where docs show examples using toLocaleString.

@ryyppy ryyppy merged commit f9a17d9 into rescript-lang:master Sep 8, 2021
@ryyppy
Copy link
Member

ryyppy commented Sep 8, 2021

Woah. Thanks!

@danwetherald
Copy link
Contributor Author

Any reason the Dom.Storage setItem was not added?

@ryyppy
Copy link
Member

ryyppy commented Sep 8, 2021

Phew, probably the wrong place to have this discussion. My wild guess is ... ppl just didn't add it, because most of us write their own bindings because the builtin ones are pretty inconsistent. And shipping new apis in the core is pretty serious business.

@danwetherald
Copy link
Contributor Author

I was only asking because it was also included in this PR. It does look like its already included, I just noticed its not documented currently.

danwetherald@47ccb0e

@ryyppy
Copy link
Member

ryyppy commented Sep 9, 2021

right, this was a while ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants