Update build schema for native compilation. #1271

bsansouci · 2017-02-24T19:27:22Z

Tell me what you think.

I'm basing this off of what ReProcessing needs. We'd also need a way to switch at compile time. You implemented some cppo-like feature but to my understanding it doesn't work with Reason (since it's another -pp?). @Schmavery and I have been using matchenv and for that we need to be able to set an environment variable per target. I'm not sure this that's the best way to do that so I didn't include in this PR the ability to set env-vars per target.

bobzhang

it would be nice that you have a working example in the comments, thanks

bobzhang · 2017-02-24T21:45:36Z

docs/docson/build-schema.json

+              "type": "string",
+              "description": "The name of the target"
+            },
+            "compilationKind": {


can we have a short name, since it is already in the context of target

bobzhang · 2017-02-24T21:46:00Z

docs/docson/build-schema.json

+        "targetItems": {
+          "type": "object",
+          "properties": {
+            "outputName": {


I don't understand, how it is different from compilation kind?

Yeah killing this.

bobzhang · 2017-02-24T21:46:34Z

docs/docson/build-schema.json

+              "description": "The compiler to use for the target"
+            },
+            "entryPoint": {
+              "type": "string",


how does it work with library, library does not have an entry point?

entryPoint only makes sense for native backend, can we make the schema enforce such invariant?

Done following your advice.

bsansouci · 2017-02-25T07:45:21Z

The way this will work with libraries is simply that bsb will ignore those targets while building a library, and will only use the dependency tree and the root project's targets to decide how to build a project.

So those targets are either used for example code in a library, or for a real project (not a lib). But if bsb ignores them when building, someone could push their package to npm (whether it's a lib or not) and people could use it without conflict (with everything module public by default). This makes a project and a library the "same thing" from the consumer's perspective :D

Remove outputname as it can be simply the target kind. Impose the invariant that JS backend doesn't need an entry point.

bobzhang · 2017-02-27T15:00:21Z

@bsansouci this looks good to me, do you want to get this merged or wait together for a working implementation?

bsansouci · 2017-02-28T19:04:25Z

I'd like to have a prototype of the implementation first. I should get one done tonight or tomorrow. Just to make sure this schema is actually usable.

bobzhang · 2017-02-28T19:28:21Z

cool, take you time reply@reply.github.com At: 02/28/17 14:04:29" data-digest="From: reply@reply.github.com At: 02/28/17 14:04:29" style=""> From: reply@reply.github.com At: 02/28/17 14:04:29 To: bucklescript@noreply.github.com Cc: HONGBO ZHANG (BLOOMBERG/ 731 LEX), comment@noreply.github.com Subject: Re: [bloomberg/bucklescript] Update build schema for native compilation. (#1271) I'd like to have a prototype of the implementation first. I should get one done tonight or tomorrow. Just to make sure this schema is actually usable. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

253e94c v1.8.2 87111bf mark this 1.8.2.git 17ae02a Merge pull request #1323 from bradking/tolerate-phony-self-reference c0dde0f Restore tolerance of self-referencing phony build statements e679202 Factor ManifestParser options into a structure f69c785 v1.8.1 7738c19 mark this 1.8.1.git 6081e81 Merge pull request #1318 from atetubou/fix_for_maxpath_test 480f899 fix normalizer test for _MAX_PATH 0c67152 v1.8.0 b98941a mark this 1.8.0.git bfa7da5 Merge pull request #1313 from adzenith/patch-3 324a117 Add _Available since Ninja 1.4._ to `deps` and `recompact` 327d6ce Merge pull request #1314 from atetubou/fix_windows_path 86f606f Remove path component limit from input of CanonicalizePath in windows e6e4984 Add `deps` and `recompact` tools to manual 7bbc708 Merge pull request #1111 from bradking/detect-cycles-early 61e347e Merge pull request #1292 from gtristan/work-around-zero-mtime 721d2a2 Drop unnecessary cycle detection in Plan::AddTarget b6f020d Teach RecomputeDirty to detect cycles in the build graph a8b5cdc Add infrastructure for efficient walks through the `Edge` graph afe3beb Refactor RecomputeDirty to take a node instead of an edge 29a6e2f Simplify BuildTest.StatFailureAbortsBuild test case b34f744 Work around mtime being set to 0 sometimes 1029064 Merge pull request #1291 from colincross/fix1290 11a934d Fix segfault on edge with no inputs 00f69c1 Merge pull request #1156 from cdbennett/windows-binary-mode-output 0142023 Merge pull request #1287 from ivadasz/dragonfly_patches 89d9d62 Merge pull request #1281 from colincross/rebuild_on_error d806aa5 Add support for DragonFly. 04d886b Always rebuild on errors a127dda Add a test that fails if a rule updates it output file but fails 036003d Move stat metric to DiskInterface d6eb8ba Merge pull request #1280 from RedBeard0531/zsh_completion_explicit_file ad54532 Make zsh completion use explicitly specified ninja files 2fc5b9e Revert 78f893b f1551b3 Merge pull request #1271 from atetubou/faster_clparser f0bb90e Reduce GetFullPathName calls 75b3385 Fix for review 3b32002 Make clparser faster 08a3220 Add string_piece_util 586bb6d Merge pull request #1267 from atetubou/clparser_perftest 5a03f4e delete n 03d0a8b use us 12ca621 add gitignore 4eac806 remove util.h 292c89f Add clparser_perftest 0b0374e Merge pull request #1255 from tchajed/bind-localhost 8a32d21 browse: Bind to localhost by default fb3c700 Merge pull request #1231 from colincross/canon_perftest_fix 1df8b6e Merge pull request #1235 from refack/patch-1 f4ea9ca Merge pull request #1232 from nicolasdespres/fix-canon_perftest 4dc4f1d Merge pull request #1237 from danw/no_reload_with_restat abcd5f3 Support restat when rebuilding manifest d560c62 Need this to build on vs2017 d6ff22b Fix compilation error in canon_perftest. d611bd4 Make travis build everything 110dae2 Fix build in canon_perftest_fix 2993752 Merge pull request #1181 from DanielWeber/issue-1161 9e71431 Merge pull request #1226 from colincross/close-fds dd2b587 Close original pipe fd in subprocesses a36f96c Merge pull request #1225 from bippum/patch-1 29ea8ea fix broken link in hacking.md 95ddaa1 Merge pull request #1220 from phajdan/master 76abf78 Fix build with uclibc 7d705a3 Merge pull request #1213 from nico/copying 78f893b replace copyright placeholder, fixes #1212 3082aa6 Merge pull request #1206 from nico/versioninfo 32c82da windows: replace deprecated GetVersionEx with recommended replacement 2263f82 Merge pull request #1205 from nico/clangclformat 32c3625 fix a clang-cl -Wformat warning 256bf89 forgot to bump version in manual for 1.7.2 release a232a7f Merge pull request #1204 from nico/vernum 14f4794 fix RELEASING wrt manual.asciidoc process fdfff11 Merge pull request #1194 from ilor/depfile-empty-path 21fc120 Merge pull request #1182 from moosotc/master ef0616e Merge pull request #1203 from nico/reldoc 474e87d Update RELEASING -- manual.asciidoc no longer has a version number 04f4bc5 Merge pull request #1201 from nico/singlecommand 8b7155b teach -t commands to optionally print only the final command 46d9a95 Improve error message when a depfile contains a bad path 1cc730d Use uint64_t for slash_bits consistently 5153ced Use POSIX_SPAWN_USEVFORK if available c4b09e1 Allow more path components b042580 Write subprocess output to stdout in binary mode git-subtree-dir: vendor/ninja git-subtree-split: 253e94c

bsansouci · 2020-03-23T20:24:29Z

Too old, closing!

bobzhang reviewed Feb 24, 2017

View reviewed changes

bsansouci added 3 commits February 24, 2017 23:59

Update build schema for native compilation.

8c07d67

Update schema.

427ccbd

Remove outputname as it can be simply the target kind. Impose the invariant that JS backend doesn't need an entry point.

Fixing the naming.

67c1413

bsansouci closed this Mar 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update build schema for native compilation. #1271

Update build schema for native compilation. #1271

Uh oh!

bsansouci commented Feb 24, 2017

Uh oh!

bobzhang left a comment

Uh oh!

bobzhang Feb 24, 2017

Uh oh!

bsansouci Feb 25, 2017

Uh oh!

bobzhang Feb 24, 2017

Uh oh!

bsansouci Feb 25, 2017

Uh oh!

bobzhang Feb 24, 2017

Uh oh!

bobzhang Feb 24, 2017

Uh oh!

bsansouci Feb 25, 2017

Uh oh!

bsansouci commented Feb 25, 2017 •

edited

Loading

Uh oh!

bobzhang commented Feb 27, 2017

Uh oh!

bsansouci commented Feb 28, 2017

Uh oh!

bobzhang commented Feb 28, 2017 via email

Uh oh!

bsansouci commented Mar 23, 2020

Uh oh!

Uh oh!

Update build schema for native compilation. #1271

Update build schema for native compilation. #1271

Uh oh!

Conversation

bsansouci commented Feb 24, 2017

Uh oh!

bobzhang left a comment

Choose a reason for hiding this comment

Uh oh!

bobzhang Feb 24, 2017

Choose a reason for hiding this comment

Uh oh!

bsansouci Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

bobzhang Feb 24, 2017

Choose a reason for hiding this comment

Uh oh!

bsansouci Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

bobzhang Feb 24, 2017

Choose a reason for hiding this comment

Uh oh!

bobzhang Feb 24, 2017

Choose a reason for hiding this comment

Uh oh!

bsansouci Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

bsansouci commented Feb 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobzhang commented Feb 27, 2017

Uh oh!

bsansouci commented Feb 28, 2017

Uh oh!

bobzhang commented Feb 28, 2017 via email

Uh oh!

bsansouci commented Mar 23, 2020

Uh oh!

Uh oh!

bsansouci commented Feb 25, 2017 •

edited

Loading