String.charCodeAt should return int

[cknitt]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charCodeAt

The charCodeAt() method of String values returns an integer between 0 and 65535 ...

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7864

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7864

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7864

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7864

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7864

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7864

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7864

commit: b48531d

[hackwaly]

I suspect that float is to cover this NaN case ""->String.charCodeAt(0)

[cknitt]

You are right. I fear I have to roll this back. 😞

This is quite non-obvious though.

We can of course mention it in the docstring, but API-wise it would be much nicer if it returned option<int>. But that would need an extra wrapper.

[hackwaly]

Maybe we can have a charCodeAtUnsafe that returns int.