Skip to content

String.charCodeAt should return int #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

String.charCodeAt should return int #7864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ec0d3
String.charCodeAt should return int
cknitt Sep 9, 2025
b48531d
CHANGELOG
cknitt Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#### :boom: Breaking Change

- Fix return type of `String.charCodeAt`. https://github.com/rescript-lang/rescript/pull/7864

#### :eyeglasses: Spec Compliance

#### :rocket: New Feature
Expand Down
2 changes: 1 addition & 1 deletion packages/@rescript/runtime/Stdlib_String.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ external compare: (string, string) => Stdlib_Ordering.t = "%compare"
@get_index external getUnsafe: (string, int) => string = ""
@send external charAt: (string, int) => string = "charAt"

@send external charCodeAt: (string, int) => float = "charCodeAt"
@send external charCodeAt: (string, int) => int = "charCodeAt"
@send external codePointAt: (string, int) => option<int> = "codePointAt"

@send external concat: (string, string) => string = "concat"
Expand Down
4 changes: 2 additions & 2 deletions packages/@rescript/runtime/Stdlib_String.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,12 @@ See [`String.charCodeAt`](https://developer.mozilla.org/en-US/docs/Web/JavaScrip
## Examples

```rescript
String.charCodeAt(`😺`, 0) == 0xd83d->Int.toFloat
String.charCodeAt(`😺`, 0) == 0xd83d
String.codePointAt(`😺`, 0) == Some(0x1f63a)
```
*/
@send
external charCodeAt: (string, int) => float = "charCodeAt"
external charCodeAt: (string, int) => int = "charCodeAt"

/**
`codePointAt(str, index)` returns the code point at position `index` within
Expand Down
Loading