Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary version of the Command line Utility #16

Merged
merged 44 commits into from
Sep 9, 2016
Merged

Preliminary version of the Command line Utility #16

merged 44 commits into from
Sep 9, 2016

Conversation

dogoepp
Copy link
Member

@dogoepp dogoepp commented Apr 26, 2016

This version has most of the features we could use on a daily basis.

The missing features are:

  • management of speed (target and current)
  • elaborate version of the oscillate command (with multiple oscillators)
  • instantiation for version 2 of the protocol

I intend to add these features later on.

In the meantime, I would appreciate if you can give me some feedback about the utility itself. Is it easy enough to use ? Does it cover your needs ?

Thanks,
Dorian

@costashatz
Copy link
Member

In the meantime, I would appreciate if you can give me some feedback about the utility itself. Is it easy enough to use ? Does it cover your needs ?

I think it has more than what we need... Good job

The missing features are:

management of speed (target and current)
instantiation for version 2 of the protocol

We should add this 2, before merging...

@dogoepp
Copy link
Member Author

dogoepp commented Jun 13, 2016

Thanks for the feedback. I agree that speed and version 2 are prerequisite to merging. Will take care of it.

@dogoepp
Copy link
Member Author

dogoepp commented Sep 9, 2016

Since we've been using this version for a long time already and I didn't have time yet to do the version 2 and speed management, I propose that we merge for now.

I'll handle the missing points in a future pull request. OK ?

@jbmouret
Copy link
Member

jbmouret commented Sep 9, 2016

Ok
On Fri, 9 Sep 2016 at 09:37, Dorian Goepp notifications@github.com wrote:

Since we've been using this version for a long time already and I didn't
have time yet to do the version 2 and speed management, I propose that we
merge for now.

I'll handle the missing points in a future pull request. OK ?


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFu8v45_oDGh44mhnUXVTWqATrUBrVUQks5qoQvLgaJpZM4IP7mJ
.

@costashatz
Copy link
Member

OK

@dogoepp dogoepp merged commit 92190da into master Sep 9, 2016
@dogoepp
Copy link
Member Author

dogoepp commented Sep 9, 2016

Merging

@dogoepp dogoepp deleted the util branch September 9, 2016 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants