Bookmarks

[manojVivek]

No description provided.

[Grafikart]

I start working on it (using a left drawer atm)

[manojVivek]

Thanks and exciting to know that! I'm assigning this to you. 🎉

@Grafikart One quick design suggestion. Can you please implement the bookmarks to be shown in the space below the address bar?

As that is how most browsers do and I think, we should keep it that way. So that, it will be more intuitive for the users than adding it to the sidebar.

What do you think?

[Grafikart]

This is my current idea

• A star in the adress bar to toggle the bookmarking
• Left bar to access bookmarks and remove them

I don't know the project so I rely on existing elements. I don't feel confident enough to add a new UI element at the moment.

I'm trying to get a first quick proof of concept. Then when I'll have more time i'll try to mirro the chrome user experience

• A popup to choose a name for the bookmark instead of using the domain name
• A bar with bookmarks
• A right click action de remove bookmarks

[manojVivek]

@Grafikart We don't have to exactly mirror the chrome user experience. But only the placement if we could do it below the address bar it would be great. The code change should be almost similar, instead of adding it to the sidebar, you will have to add it to the NavigationControls component.

Something like:

[Grafikart]

Ok do you think we should ask the user for a title or use the domain name for the bookmark ?

[manojVivek]

To start with I would suggest, we can just take the page title from <title /> tag and use it. If the title is missing we can fallback to the domain name.

…

On Thu, 4 Jun 2020 at 11:03 PM, Jonathan ***@***.***> wrote: Ok do you think we should ask the user for a title or use the domain name for the bookmark ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJZKYHHJSUOPGGSCZS6QATRU7LGBANCNFSM4IUACT7A> .