feat: add support for local devtools extensions #259
Conversation
|
Decided to use the BrowserWindow.addDevToolsExtension to keep the changes minimal. Also, the version of electron-devtools-installer that's being used is using the same under the hood. Moving to WDYT? |
| .replace(/\/$/, '') | ||
| .split('/') | ||
| .pop(); | ||
| const isLocalExtension = fs.statSync(extensionId).isDirectory(); |
There was a problem hiding this comment.
@prashantpalikhe Can you please move this logic to the main process? We should try and keep node usage as less as possible in the renderer.
There was a problem hiding this comment.
Updated. Can you check?
| @@ -167,7 +174,9 @@ export default function ExtensionsManager({triggerNavigationReload}) { | |||
|
|
|||
| <FormHelperText className={styles.extensionsNotice}> | |||
| Note: Only DevTool extensions will work properly, other general | |||
| browser extensions may not work as intended. | |||
| browser extensions may not work as intended. Local devtools | |||
| extensions are also supported. Instead of ID, use absolute path to | |||
There was a problem hiding this comment.
@prashantpalikhe If possible can you please add an open icon near the help icon and let the user select the folder by using the file explorer?
It will a simple change using the inbuilt dialog API, check out a sample usage here - https://github.com/manojVivek/responsively-app/blob/master/desktop-app/app/menu.js#L176
There was a problem hiding this comment.
Updated. Can you check?
prashantpalikhe
force-pushed
the
feature/implement-support-for-local-devtools-extension
branch
from
d94816a
to
d4c2d56
Compare
prashantpalikhe
force-pushed
the
feature/implement-support-for-local-devtools-extension
branch
2 times, most recently
from
910b62f
to
2f07890
Compare
prashantpalikhe
force-pushed
the
feature/implement-support-for-local-devtools-extension
branch
from
2f07890
to
fff4ff9
Compare
|
@prashantpalikhe These looks great, merging it in. Looking forward to more collaboration in the future! 🙌 |
|
@all-contributors Please add @prashantpalikhe to code. |
|
I've put up a pull request to add @prashantpalikhe! 🎉 |
Implement #237