RESTEASY-2454: Remove finalize from ClientResponse to improve gc #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve gc remove finalize from ClientResponse and re-add finalize at the specific client implementation Make finalize addition configurable with the ReactorNettyClientHttpEngine RestEasyClientReponse.
anilgursel
approved these changes
Dec 16, 2019
asoldano
reviewed
Dec 16, 2019
There was a problem hiding this comment.
Thanks for the PR, this definitely looks good. I did something similar for the ApacheHttpClient43Engine some time ago. We have a few failures of the added tests in reactor netty component, perhaps the 2s timeout is not enough; can you try fixing that, please? Thanks
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve gc remove finalize from ClientResponse and re-add finalize
at the specific client implementation
Make finalize addition configurable with the ReactorNettyClientHttpEngine RestEasyClientReponse.