JsonDeserialize : int to bool

[rlyczynski]

Fixes bug where JsonDeserializer could not deserialize an integer to a boolean property.

[rlyczynski]

Couldn't figure out why this was here. The SimpleJson deserializer returns a string object with the value 1 (no quotes) if the json string is {"index": "1"}. So converting the value to a string to strip the quotes before you convert doesn't make sense and by doing this it wont allow you to convert something like {"index": 1} to a bool.

[haacked]

Hmm, I'm not sure either. My guess is to handle this case:

[Fact]
+    public void Can_Deserialize_Int_to_Bool()
+    {
+      var d = new JsonDeserializer();
+      var response = new RestResponse { Content = "{\"IsCool\":\"1\"}" };
+      var p = d.Deserialize<PersonForJson>(response);
+
+      Assert.True(p.IsCool);
+    }

Does that test also pass before and after?

[rlyczynski]

That test would pass neither before nor after the change. The Convert class can only convert the string "true" or "false" to a bool (http://msdn.microsoft.com/en-us/library/86hw82a3(v=vs.90).aspx).

This is the reason {"IsCool": 1} would fail before, because that line converts 1 to a string before trying to convert to bool.

[haacked]

Good. I wouldn't want that test to pass. ;)

Thanks for the contribution!

[haacked]

Thanks!