XmlDeserializer shoud be parent class of XmlAttributeDeserializer #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
haacked
added a commit
that referenced
this pull request
Sep 29, 2013
XmlDeserializer shoud be parent class of XmlAttributeDeserializer
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the only way how to manage code in this classes in inheritance. XmlDeserializer had some new features, but XmlAttributeDeserializer not. I think they shoud be same, but XmlAttributeDeserializer with using DeserializeAsAttribute.
I splited tests XmlTest.cs into XmlDeserializerTest.cs and XmlAttributeDeserializerTest.cs for sure.
My motivation was this commit c68de9d#diff-b4b64956e6de3b7255635b2b3f02bd76 which broke deserization in my project. And I found only 2 tests for XmlAttributeDeserializer!