UrlEncode fix for input strings > 32766 limit #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial code by @jeffthieleke-wf with my additions of null parameter check, correct maxLength of 32766, and matching indentations per @haacked.
|
Unit tests? |
|
Will have to be next week now. The rest of the day is shot.
|
|
Ok, plans changed. I was able to squeeze in a few minutes and write 3 unit tests for it. See if that tickles your fancy. :) |
|
I'll be stoked when this is merged in. Thanks, @robertmiles3 ! |
|
Great! Though you're missing one test.
Gotta test all those boundary conditions. But I'm satisfied with this. |
haacked
added a commit
that referenced
this pull request
Oct 18, 2013
UrlEncode fix for input strings > 32766 limit
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code by @jeffthieleke-wf with my additions of null parameter
check, correct maxLength of 32766, and matching indentations per
@haacked.