Update RestRequest.cs #463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new method to add bytes as it was a file of specific content type. This is useful to send a gzipped data on multipart request without the use of temporary file
There was a problem hiding this comment.
Thanks for submitting a PR! Please fix up the white space. RestSharp uses tabs, not spaces. Also, this new line here is unnecessary.
|
Looks good. Just some minor commens. |
|
This needs some work before it gets merged in. I'm not sure that the method name follows the pattern set in the class and I don't think we need to have a default value on the contentType parameter. It also needs unit tests. |
hallem
pushed a commit
that referenced
this pull request
Aug 4, 2015
|
manually merged this in with some modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method to add bytes as it was a file of specific content type. This is useful to send a gzipped data on multipart request without the use of temporary file