Added support for JsonArray and JsonObject deserialization when target type is specified as System.Object #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind adding a unit test that fails without this change? |
|
Will do! |
Fixed an overload, which is not available in compact framework.
… when their target type is specified as "System.Object" instead of a more specific type. * The side effect of this is that now you can recursively deserialize a JSON object that has mixed value types by specifying Dictionary<string, object> as the deserialization target.
Conflicts: RestSharp/Deserializers/JsonDeserializer.cs
|
I've added a unit test as well as some additional code. Please see the commit message for details and of course, let me know if you have any questions. |
ryno1234
changed the title
haacked
added a commit
that referenced
this pull request
Mar 20, 2014
Added support for JsonArray and JsonObject deserialization when target type is specified as System.Object
|
Thanks! 👍 |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #318