piped inspection results through parserstate - inspector is officially useless, ...and parsetree inspections are officially broken.

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -69,11 +69,11 @@ public App(IVBE vbe,
         private void State_StatusMessageUpdate(object sender, RubberduckStatusMessageEventArgs e)
         {
             var message = e.Message;
-            if (message == ParserState.LoadingReference.ToString())
-            {
-                // note: ugly hack to enable Rubberduck.Parsing assembly to do this
-                message = RubberduckUI.ParserState_LoadingReference;
-            }
+            //if (message == ParserState.LoadingReference.ToString())
+            //{
+            //    // note: ugly hack to enable Rubberduck.Parsing assembly to do this
+            //    message = ParsingText.ParserState_LoadingReference;
+            //}
 
             _stateBar.SetStatusLabelCaption(message, _parser.State.ModuleExceptions.Count);
         }

RetailCoder.VBE/Refactorings/ExtractInterface/ExtractInterfaceRefactoring.cs

@@ -122,7 +122,7 @@ private void AddInterface()
         private int _insertionLine;
         private void _state_StateChanged(object sender, EventArgs e)
         {
-            if (_state.Status != ParserState.Ready)
+            if (!_state.Status.IsResolvedOrReady())
             {
                 return;
             }

RetailCoder.VBE/UI/CodeExplorer/Commands/FindAllImplementationsCommand.cs

@@ -19,7 +19,7 @@ public FindAllImplementationsCommand(RubberduckParserState state, Command.FindAl
 
         protected override bool CanExecuteImpl(object parameter)
         {
-            return _state.Status == ParserState.Ready &&
+            return _state.Status.IsResolvedOrReady() &&
                    (parameter is CodeExplorerComponentViewModel ||
                     parameter is CodeExplorerMemberViewModel);
         }

RetailCoder.VBE/UI/CodeExplorer/Commands/FindAllReferencesCommand.cs

@@ -19,7 +19,7 @@ public FindAllReferencesCommand(RubberduckParserState state, Command.FindAllRefe
 
         protected override bool CanExecuteImpl(object parameter)
         {
-            return _state.Status == ParserState.Ready &&
+            return _state.Status.IsResolvedOrReady() &&
                 parameter != null &&
                 !(parameter is CodeExplorerCustomFolderViewModel);
         }

RetailCoder.VBE/UI/CodeExplorer/Commands/IndentCommand.cs

@@ -42,7 +42,7 @@ protected override bool CanExecuteImpl(object parameter)
 
             if (parameter is CodeExplorerProjectViewModel)
             {
-                if (_state.Status != ParserState.Ready)
+                if (!_state.Status.IsResolvedOrReady())
                 {
                     return false;
                 }
@@ -56,7 +56,7 @@ protected override bool CanExecuteImpl(object parameter)
 
             if (parameter is CodeExplorerCustomFolderViewModel)
             {
-                if (_state.Status != ParserState.Ready)
+                if (!_state.Status.IsResolvedOrReady())
                 {
                     return false;
                 }
@@ -67,7 +67,7 @@ protected override bool CanExecuteImpl(object parameter)
                         .Any(d => d.Annotations.All(a => a.AnnotationType != AnnotationType.NoIndent));
             }
 
-            return _state.Status == ParserState.Ready;
+            return _state.Status.IsResolvedOrReady();
         }
 
         protected override void ExecuteImpl(object parameter)

RetailCoder.VBE/UI/CodeExplorer/Commands/RenameCommand.cs

@@ -26,7 +26,7 @@ public RenameCommand(IVBE vbe, RubberduckParserState state, IRenameDialog view,
 
         protected override bool CanExecuteImpl(object parameter)
         {
-            return _state.Status == ParserState.Ready && parameter is ICodeExplorerDeclarationViewModel;
+            return _state.Status.IsResolvedOrReady() && parameter is ICodeExplorerDeclarationViewModel;
         }
 
         protected override void ExecuteImpl(object parameter)

RetailCoder.VBE/UI/Command/AddTestMethodCommand.cs

@@ -45,7 +45,10 @@ public AddTestMethodCommand(IVBE vbe, RubberduckParserState state) : base(LogMan
 
         protected override bool CanExecuteImpl(object parameter)
         {
-            if (_state.Status != ParserState.Ready || _vbe.ActiveCodePane == null) { return false; }
+            if (_state.Status.IsResolvedOrReady() || _vbe.ActiveCodePane == null)
+            {
+                return false;
+            }
 
             var testModules = _state.AllUserDeclarations.Where(d =>
                         d.DeclarationType == DeclarationType.ProceduralModule &&

RetailCoder.VBE/UI/Command/AddTestMethodExpectedErrorCommand.cs

@@ -52,7 +52,7 @@ protected override bool CanExecuteImpl(object parameter)
         {
             var pane = _vbe.ActiveCodePane;
             {
-                if (_state.Status != ParserState.Ready || pane.IsWrappingNullReference)
+                if (_state.Status.IsResolvedOrReady() || pane.IsWrappingNullReference)
                 {
                     return false;
                 }

RetailCoder.VBE/UI/Command/CommandBase.cs

@@ -4,6 +4,7 @@
 using System.Runtime.InteropServices;
 using System.Windows.Input;
 using NLog;
+using Rubberduck.Parsing.VBA;
 using Rubberduck.Settings;
 
 namespace Rubberduck.UI.Command

RetailCoder.VBE/UI/Command/FindAllImplementationsCommand.cs

@@ -54,7 +54,7 @@ private Declaration FindNewDeclaration(Declaration declaration)
 
         private void _state_StateChanged(object sender, ParserStateEventArgs e)
         {
-            if (e.State != ParserState.Ready) { return; }
+            if (e.State.IsResolvedOrReady()) { return; }
 
             if (_viewModel == null) { return; }
 
@@ -90,7 +90,7 @@ private void UpdateTab()
 
         protected override bool CanExecuteImpl(object parameter)
         {
-            if (_vbe.ActiveCodePane == null || _state.Status != ParserState.Ready)
+            if (_vbe.ActiveCodePane == null || _state.Status.IsResolvedOrReady())
             {
                 return false;
             }
@@ -103,7 +103,7 @@ protected override bool CanExecuteImpl(object parameter)
 
         protected override void ExecuteImpl(object parameter)
         {
-            if (_state.Status != ParserState.Ready)
+            if (_state.Status.IsResolvedOrReady())
             {
                 return;
             }