sync next #246
Merged
sync next #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new automagic factory for SettingsForm Update unit tests
Implement wrapper Make unit tests on registry safe
Removes extraneous line breaks in license text displayed in the installer.
Kill Copying of Rubberduck.Inspections.dll Add explicit dependency on Rubberduck.Inspections.dll
Widen experimentalTypes argument Type Relax IsBasedOn definition to include Interface inheritance
We want to be able to restrict type visibility as much as possible for all projects, especially so if we want to execute arbitrary user-code (plugins). For that purpose as many types as possible should be marked internal. To still be able to test these types, they must be visible to the test-project. See #1600
While we're at it, also splinch away Rubberduck.API into a separate project. Note that this is basically breaking the release process, since we no more ship the API with Rubberduck directly
Also fix a few minor warnings on the sidelines
Categorized, tweaked, and added refactor/rename tests.
Provide a method of pumping COM objects in a synchronous block (no user-facing changes)
…iner DisposalActionContainer (no user-facing changes)
Makes project declarations implement IDisposable (no user-facing changes)
Fixes StackOverflowException. TODO: Extract expression-evaluation logic into Rubberduck.Parsing and make it a resolver step to annotate all expressions with type info.
Minor tweaks
Update UiContext to provide the GetEntryAssembly method to replace the Assembly.GetEntryAssembly() because the latter can return null and thus is not reliable.
…d of playing Assembly circus
Installer no longer removes user settings. If this comes up as an issue, let it be by-design.
…use we didn't include the standard library.... Heisenbug!
…check for error state.
Fix Heisenbug in unit test.
…hat'll make AppVeyor happy?
German i18n adjustments for Release 2.2.0
replacing test as per comments
Fixes broken unit test.
addresses review comments, ref. #3868 / unreachable case inspection
Add host information in About dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.