Bring in refs WIP #252
Merged
Bring in refs WIP #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ProjectRefs
…nto ProjectRefs
…geSourceConverter inherit it.
Centralizing work done so far. The XAML work is pretty much done (not 100% sure about that "priority" tab though), and the library finder is implemented. Todo: put the pieces together.
…cification Currently, the what annotations are legal is not very intuitive. So, we will only put legal annotations on stuff. What is left are illegal annotations. This changes the counting for illegal references in identifiers and where the annotation sections for variables and members end.
Annotations only get scoped to recipients now for which they have a corresponding flag.
fix for duplicate VBERuntime and VbeRuntime
…tionInspection Fix illegal annotation inspection
Case Corrections
Previously, the fix silently expected to be handed an inspection result with a parser context. Module inspection results have none. Moreover it always used Ignore whereas modules require IgnoreModule.
This removes some bugs around module inspection results, removes the use of the code modules and makes the quickfix honor indentation. Moreover, it now recognizes an existing Ignore annotation that it not the first one in an annotation list.
These annotation can be placed anywhere and do not necessarily bind to a declaration or identifier reference. Closes rubberduck-vba#4594
Rewrite ignore once quickfix
…tions Always deem annotations with GeneralAnnotation flag legal
Various quick bug fixes for 2.3 patch release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.