Skip to content

Conversation

rcoh
Copy link
Contributor

@rcoh rcoh commented Apr 16, 2020

Rename external assets:

  • sgrep is now semgrep-core
  • sgrep_line is now semgrep
  • We won't need a patch for the next brew release, all changes are included.
  • Docker will push to the new repo
  • Stuff that mentions sgrep in user facing sgrep lint now mention semgrep

@rcoh rcoh marked this pull request as ready for review April 21, 2020 17:50
@rcoh rcoh requested review from DrewDennison and brendongo April 21, 2020 19:32
@rcoh rcoh merged commit 6a59cf7 into develop Apr 21, 2020
@rcoh rcoh deleted the russell/semgrep-rename branch April 21, 2020 19:42
underyx added a commit that referenced this pull request Apr 23, 2020
* * sgrep/tests/java/dots_vardef.java: (#497)

Just test case showing this can now be parsed thx to the modifiction
in pfff.
This is related to https://github.com/returntocorp/enterprise/issues/77

Test plan:
test file included
make test

* Fix the ubuntu 16.04 build job (#496)

* cd into github before initializing submodules

* run on PR for testing

* remove git installation

* Break out git & python installs separately

* Update the job

* Add Python installation step

* more installs never hurt anyone

* oy

* enough deps now?

* enough deps now?

* give it a temp dir

* Fix path

* give up on GH initialized submoudles

* log some stuff

* too much help

* Add missing opam install -y

* remove duplicate &&

* Fix file name

* more file name fixups

* Dangerously close to working!

* Add shebang to the Python install script

* Don't run on PRs

* Delete lots of stuff and use the new base image (#503)

* Delete lots of stuff and use the new base image

* Also build the release for testing

* Update the 1804 release job

* Good bye install python

* Convert more jobs to use the new images

* Backing out building the release for PRs

* fix exit codes (#508)

* capture and make error json for single pattern mode as well

* need sys.exit under nuitka sadly. clean up some exception handling and add better exit code

* revert

* blacken

Co-authored-by: Isaac Evans <ine@mit.edu>
Co-authored-by: Drew Dennison <drew@returntocorp.com>

* Run validate on sgrep-rules during testing (#494)

* brew: point to a specific commit (#515)

* Produce sha checksums for release assets (#516)

* Create checksum objects on release

* Fix workflow

* Fix checksum bug & swich to fast-builders

* Use real release scripts instead of stubs

* Add a couple more gitignore patterns (#518)

* Update README.md

* misc (#524)

* * sgrep/lib/matching_generic.mli: interfaces are useful!

* * sgrep/tests/java/dots_params.sgrep: it works now!

* change to semgrep.live for updating docker image

* GitBook: [develop] 8 pages modified

* update pfff to support void 0 in javascript (#517)

Co-authored-by: Isaac Evans <ine@mit.edu>

* Update README.md (#527)

* Update README.md

* Add badge for homebrew

* Fix brew release

* Starting the rename process for external assets (#486)

* Working towards semgrep rename for all _external_ resources

* Switch ref for HEAD

* Keep old symlink around

* Fix the main package

* brew formula fixups

* Silence mypy check of setup tools

* Head before stable for brew audit

* There is no head audit, remove

* Fix from image

* Push to the new dockerhub repo

* Did the merge wrong

* Another missed rename

* last one hopefully...

* Produce the right executable from dune

* Refactor sgrep_lint (#509)

Main goal of this part of the refactor was to break up the monolithic functions in sgrep_main.py and to reduce the places where raw dictionaries were being used.

This was accomplished by:
- bringing up parallel commands (--validate/--dump-ast) from sgrep_main.py and into cli.py and having their relevant code in separate files if applicable
- Introducing new classes to encapsulate a Rule, Pattern, RuleMatch, and Pattern Match. Note that these new classes are not fully thought through so still expose access to underlying dictionary as an escape hatch.
- Introduce CoreRunner class that handles running semgrep-core and parsing output into RuleMatch objects
- Separate autofix functionality from rule parsing code
- Clarify some variable names

Also removed pytest code from pre-commit ignore and made it mypy compliant.

* readme: rename sgrep to semgrep (#528)

* Update `--head` pointer of homebrew recipe (#530)

Now that the branch is merged, head should point to develop

* Move sgrep to semgrep-core (#531)

Renames the sgrep directory containing the ocaml code to semgrep-core and update all the build jobs

* Don't copy binaries into top level (#541)

* Improve README.md flow (#532)

This commit improves the readability of semgrep's README for new users:

- Clearly explain examples
- Introduce pattern composition before displaying it to the user

Also takes advantage of syntax highlighting in example commands

* Rename sgrep_lint to semgrep (#534)

* Fix osx release script (#543)

* Update README for new homebrew repo (#545)

* Update README.md

* Delete brew recipe (moved to external repo, change test to test stable)

* Add docker push to release workflow (#546)

* Push docker container on merge to develop (#548)

* Push to docker on PRs to develop (#547)

* Rename sgrep to semgrep in other markdown files (#542)

* Remove leading v in release docker tag (#549)

* Release 0.5.0b1

* update pfff to latest (#560)

Co-authored-by: Isaac Evans <ine@mit.edu>

* Update README.md (#558)

* Change endpoint to get release information (#552)

* Update README.md (#559)

Add a link to semgrep-rules under the patterns field

* run-lint-tests: Fix diff command

Co-authored-by: Yoann Padioleau <pad@returntocorp.com>
Co-authored-by: Russell Cohen <russell.r.cohen@gmail.com>
Co-authored-by: Isaac Evans <409041+ievans@users.noreply.github.com>
Co-authored-by: Isaac Evans <ine@mit.edu>
Co-authored-by: Drew Dennison <drew@returntocorp.com>
Co-authored-by: Brendon Go <brendon.go@gmail.com>
Co-authored-by: Drew Dennison <drew@drewdennison.com>
Co-authored-by: Daghan Altas <daghan@users.noreply.github.com>
Co-authored-by: Nathaniel Brahms <nbrahms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants