bug: ReVanced crashes when restarting to apply setting

[CnC-Robert]

Type

Error at runtime

Bug description

When restarting to apply a setting, the app crashes seemingly at random.
I have not been able to find a pattern for when it happens.

Steps to reproduce

1. Open the settings menu
2. Change a setting that requires a restart
3. Click restart
4. Repeat until the app crashes

Relevant log output

07-31 19:11:02.700 16281 16281 D AndroidRuntime: Shutting down VM
07-31 19:11:02.701 16281 16281 E AndroidRuntime: FATAL EXCEPTION: main
07-31 19:11:02.701 16281 16281 E AndroidRuntime: Process: app.revanced.android.youtube, PID: 16281
07-31 19:11:02.701 16281 16281 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Class.getName()' on a null object reference
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.content.ComponentName.<init>(ComponentName.java:133)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.content.Intent.<init>(Intent.java:7117)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment.reboot(ReVancedSettingsFragment.java:213)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment.lambda$rebootDialog$2$app-revanced-integrations-settingsmenu-ReVancedSettingsFragment(ReVancedSettingsFragment.java:218)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:4)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:175)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:201)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7870)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
07-31 19:11:02.701 16281 16281 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Screenshots or videos

screen-20220731-191836.mp4

Solution

I don't know

Additional context

No response

[Sculas]

@oSumAtrIX Any idea why homeActivityClass is never being set?

https://github.com/revanced/revanced-integrations/blob/d7833ec2e7c82104c3c567a7e55cb388a71bd9f0/app/src/main/java/app/revanced/integrations/settingsmenu/ReVancedSettingsFragment.java#L34

[TheJeterLP]

@oSumAtrIX Any idea why homeActivityClass is never being set?

https://github.com/revanced/revanced-integrations/blob/d7833ec2e7c82104c3c567a7e55cb388a71bd9f0/app/src/main/java/app/revanced/integrations/settingsmenu/ReVancedSettingsFragment.java#L34

Probably that was set by vanced somewhere in bytecode. Should be an easy fix