Skip to content

COO-942: Adding deployment of common accelerator perses dashboard #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

COO-942: Adding deployment of common accelerator perses dashboard #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 200 additions & 0 deletions pkg/controllers/uiplugin/accelerators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,200 @@
package uiplugin

import (
persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
persesv1 "github.com/perses/perses/pkg/model/api/v1"
"github.com/perses/perses/pkg/model/api/v1/common"
"github.com/perses/perses/pkg/model/api/v1/dashboard"
"github.com/perses/perses/pkg/model/api/v1/variable"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/ptr"
)

func newAcceleratorsDatasource(namespace string) *persesv1alpha1.PersesDatasource {
return &persesv1alpha1.PersesDatasource{
TypeMeta: metav1.TypeMeta{
APIVersion: persesv1alpha1.GroupVersion.String(),
Kind: "PersesDatasource",
},
ObjectMeta: metav1.ObjectMeta{
Name: "accelerators-thanos-querier-datasource",
Namespace: namespace,
Labels: map[string]string{
"app.kubernetes.io/managed-by": "observability-operator",
},
},
Spec: persesv1alpha1.DatasourceSpec{
Config: persesv1alpha1.Datasource{
DatasourceSpec: persesv1.DatasourceSpec{
Display: &common.Display{
Name: "acceelerators datasource",
},
Default: true,
Plugin: common.Plugin{
Kind: "PrometheusDatasource",
Spec: map[string]interface{}{
"proxy": map[string]interface{}{
"kind": "HTTPProxy",
"spec": map[string]interface{}{
"url": "https://thanos-querier.openshift-monitoring.svc.cluster.local:9091",
"secret": "accelerators-thanos-querier-datasource-secret",
},
},
},
},
},
},
Client: &persesv1alpha1.Client{
TLS: &persesv1alpha1.TLS{
Enable: true,
CaCert: &persesv1alpha1.Certificate{
Type: persesv1alpha1.CertificateTypeFile,
CertPath: "/ca/service-ca.crt",
},
},
},
},
}
}

func newAcceleratorsDashboard(namespace string) *persesv1alpha1.PersesDashboard {
return &persesv1alpha1.PersesDashboard{
TypeMeta: metav1.TypeMeta{
APIVersion: persesv1alpha1.GroupVersion.String(),
Kind: "PersesDashboard",
},
ObjectMeta: metav1.ObjectMeta{
Name: "accelerators-dashboard",
Namespace: namespace,
Labels: map[string]string{
"app.kubernetes.io/managed-by": "observability-operator",
},
},
Spec: persesv1alpha1.Dashboard{
DashboardSpec: persesv1.DashboardSpec{
Display: &common.Display{
Name: "Accelerators common metrics",
},
Variables: []dashboard.Variable{
{
Kind: variable.KindList,
Spec: &dashboard.ListVariableSpec{
Name: "cluster",
ListSpec: variable.ListSpec{
Display: &variable.Display{
Hidden: false,
},
AllowAllValue: false,
AllowMultiple: false,
Sort: ptr.To(variable.SortAlphabeticalAsc),
Plugin: common.Plugin{
Kind: "PrometheusLabelValuesVariable",
Spec: map[string]interface{}{
"labelName": "cluster",
"matchers": []interface{}{
"up{job=\"kubelet\", metrics_path=\"/metrics/cadvisor\"}",
},
},
},
},
},
},
},
Panels: map[string]*persesv1.Panel{
"0_0": getPanel("GPU Utilization", "accelerator_gpu_utilization"),
"0_1": getPanel("Memory Used Bytes", "accelerator_memory_used_bytes"),
"0_2": getPanel("Memory Total Bytes", "accelerator_memory_total_bytes"),
"0_3": getPanel("Power Usage (watts)", "accelerator_power_usage_watts"),
"0_4": getPanel("Temperature (celcius)", "accelerator_temperature_celcius"),
"0_5": getPanel("SM Clock(hertz)", "accelerator_sm_clock_hertz"),
"0_6": getPanel("Memory Clock(hertz)", "accelerator_memory_clock_hertz"),
},
Layouts: []dashboard.Layout{
{
Kind: dashboard.KindGridLayout,
Spec: dashboard.GridLayoutSpec{
Display: &dashboard.GridLayoutDisplay{
Title: "Accelerators",
Collapse: &dashboard.GridLayoutCollapse{
Open: true,
},
},
Items: []dashboard.GridItem{
getGridItem(0, 0, "#/spec/panels/0_0"),
getGridItem(12, 0, "#/spec/panels/0_1"),
getGridItem(0, 7, "#/spec/panels/0_2"),
getGridItem(12, 7, "#/spec/panels/0_3"),
getGridItem(0, 14, "#/spec/panels/0_4"),
getGridItem(12, 14, "#/spec/panels/0_5"),
getGridItem(0, 21, "#/spec/panels/0_6"),
},
},
},
},
},
},
}
}

func getPanel(panelName, targetMetric string) *persesv1.Panel {
return &persesv1.Panel{
Kind: "Panel",
Spec: persesv1.PanelSpec{
Display: persesv1.PanelDisplay{
Name: panelName,
},
Plugin: common.Plugin{
Kind: "TimeSeriesChart",
Spec: map[string]interface{}{
"legend": map[string]interface{}{
"mode": "list",
"position": "bottom",
"values": []interface{}{}, // Empty array
},
"visual": map[string]interface{}{
"areaOpacity": 1,
"connectNulls": false,
"display": "line",
"lineWidth": 0.25,
"stack": "all",
},
"yAxis": map[string]interface{}{
"format": map[string]interface{}{
"unit": "decimal",
},
"min": 0,
},
},
},
Queries: []persesv1.Query{
{
Kind: "TimeSeriesQuery",
Spec: persesv1.QuerySpec{
Plugin: common.Plugin{
Kind: "PrometheusTimeSeriesQuery",
Spec: map[string]interface{}{
"datasource": map[string]interface{}{
"kind": "PrometheusDatasource",
},
"query": targetMetric,
"seriesNameFormat": "{{vendor_id}}",
},
},
},
},
},
},
}
}

func getGridItem(xPos, yPos int, ref string) dashboard.GridItem {
return dashboard.GridItem{
X: xPos,
Y: yPos,
Width: 12,
Height: 7,
Content: &common.JSONRef{
Ref: ref,
},
}
}
3 changes: 3 additions & 0 deletions pkg/controllers/uiplugin/components.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ func pluginComponentReconcilers(plugin *uiv1alpha1.UIPlugin, pluginInfo UIPlugin
components = append(components, reconciler.NewUpdater(newPerses(namespace, pluginInfo.PersesImage), plugin))
}

components = append(components, reconciler.NewUpdater(newAcceleratorsDatasource(namespace), plugin))
components = append(components, reconciler.NewUpdater(newAcceleratorsDashboard(namespace), plugin))

return components
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/uiplugin/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
osv1 "github.com/openshift/api/console/v1"
osv1alpha1 "github.com/openshift/api/console/v1alpha1"
operatorv1 "github.com/openshift/api/operator/v1"
persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
appsv1 "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
Expand All @@ -25,7 +26,6 @@ import (
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/predicate"

persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
uiv1alpha1 "github.com/rhobs/observability-operator/pkg/apis/uiplugin/v1alpha1"
"github.com/rhobs/observability-operator/pkg/reconciler"
)
Expand Down
6 changes: 3 additions & 3 deletions pkg/controllers/uiplugin/monitoring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import (

osv1 "github.com/openshift/api/console/v1"
osv1alpha1 "github.com/openshift/api/console/v1alpha1"
persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
persesconfig "github.com/perses/perses/pkg/model/api/config"
"github.com/perses/perses/pkg/model/api/v1/common"
"golang.org/x/mod/semver"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"

persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
persesconfig "github.com/perses/perses/pkg/model/api/config"
"github.com/perses/perses/pkg/model/api/v1/common"
uiv1alpha1 "github.com/rhobs/observability-operator/pkg/apis/uiplugin/v1alpha1"
)

Expand Down
2 changes: 1 addition & 1 deletion pkg/operator/scheme.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
osv1 "github.com/openshift/api/console/v1"
osv1alpha1 "github.com/openshift/api/console/v1alpha1"
operatorv1 "github.com/openshift/api/operator/v1"
persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
monv1 "github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1"
monitoringv1 "github.com/rhobs/obo-prometheus-operator/pkg/apis/monitoring/v1"
corev1 "k8s.io/api/core/v1"
Expand All @@ -12,7 +13,6 @@ import (
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
clientgoscheme "k8s.io/client-go/kubernetes/scheme"

persesv1alpha1 "github.com/perses/perses-operator/api/v1alpha1"
rhobsv1alpha1 "github.com/rhobs/observability-operator/pkg/apis/monitoring/v1alpha1"
uiv1alpha1 "github.com/rhobs/observability-operator/pkg/apis/uiplugin/v1alpha1"
)
Expand Down
Loading