Skip to content

Conversation

yevgeny-shnaidman
Copy link
Contributor

Common accelerator perses dashboard contains metrics that are common for different accelerators' vendors. The dashboard will be deployed along with UI plugin

@yevgeny-shnaidman yevgeny-shnaidman requested a review from a team as a code owner May 20, 2025 10:03
@yevgeny-shnaidman yevgeny-shnaidman requested review from jan--f and danielmellado and removed request for a team May 20, 2025 10:03
Copy link

openshift-ci bot commented May 20, 2025

Hi @yevgeny-shnaidman. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Common accelerator perses dashboard contains metrics that are common for
different accelerators' vendors. The dashboard will be deployed along
with UI plugin
@yevgeny-shnaidman yevgeny-shnaidman force-pushed the yevgeny/add-common-dashboard branch from 164cfb0 to 1f15081 Compare May 20, 2025 10:50
@jgbernalp jgbernalp changed the title Adding deployment of common accelerator perses dashboard COO-942: Adding deployment of common accelerator perses dashboard May 20, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 20, 2025

@yevgeny-shnaidman: This pull request references COO-942 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Common accelerator perses dashboard contains metrics that are common for different accelerators' vendors. The dashboard will be deployed along with UI plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

/lgtm

@etmurasaki
Copy link
Contributor

/label qe-approved

Copy link

openshift-ci bot commented May 20, 2025

@etmurasaki: The label(s) qe-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PeterYurkovich
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f9a161e into rhobs:main May 21, 2025
11 checks passed
openshift-merge-bot bot pushed a commit that referenced this pull request May 28, 2025
* fix: further fix github action olm publish failure (#742)

* fix: allow to create a logging plugin without a loki stack (#743)

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>

* build: check for go installation before setting up a new environment (#745)

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>

* feat: enable deployment of common accelerator perses dashboard (#744)

Common accelerator perses dashboard contains metrics that are common for
different accelerators' vendors. The dashboard will be deployed along
with UI plugin

* fix:  Update main.go korrel8r tag to release-coo-1.2 (#746)

* feat: add monitoring-plugin stream 0.4 and 0.5 (#747)

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>

* feat: add CRD scaffolding for cluster observability / signal manager (#748)

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* chore: update troubleshooting plugin image tag (#749)

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>

* fix: add default value to logs schema (#751)

* fix: check lokistack value on lokistack discovery (#753)

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>

* chore: update troubleshooting plugin to new image (#755)

* chore: update logging image to v6.1.1 (#756)

* chore(release): 1.2.0 (new cut)

---------

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Co-authored-by: lihongyan1 <hongyli@redhat.com>
Co-authored-by: Gabriel Bernal <gbernal@redhat.com>
Co-authored-by: Yevgeny Shnaidman <60741237+yevgeny-shnaidman@users.noreply.github.com>
Co-authored-by: Alan Conway <aconway@redhat.com>
Co-authored-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants