-
Notifications
You must be signed in to change notification settings - Fork 0
Description
NOTE: This issue should probably be worked on in conjunction with #83.
We need to make some enhancements to the image lightbox (#68):
-
The lightbox doesn't currently support images that use the
svg::
macro. This is problematic because we use this macro to support embedded SVGs that honor our CSS styles for light and dark mode (example). -
We should probably add a background to the lightbox that's the same size as the image. Currently, images with transparent backgrounds look messy when overlaid on top of page content (example).
-
We need to be able to selectively turn off the lightbox for certain images (both block and inline images). We could probably handle this with a role similar to the
remove-ext-icon
role that we use for selectively disabling the external link icon.
Currently, the lightbox is enabled for the badge icons on the Connection methods comparison page, which is a little silly:
But more importantly, when we enable the lightbox for thesvg::
macro, we'll need to be able to turn off the lightbox for the graphics on the landing page: