Skip to content

Conversation

colegoldsmith
Copy link
Collaborator

@colegoldsmith colegoldsmith commented Jan 31, 2024

  • Tabs have a new outlined design
  • Tab titles now scroll horizontally by default, showing arrow buttons when there is scrollable content
Screenshot 2024-02-07 at 1 48 49 PM

@mlr
Copy link
Contributor

mlr commented Jan 31, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Jan 31, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 2, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 2, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 6, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 6, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 6, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 6, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

@colegoldsmith colegoldsmith changed the title Testing tabs improvements Tabs improvements Feb 7, 2024
@colegoldsmith colegoldsmith linked an issue Feb 7, 2024 that may be closed by this pull request
@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented Feb 7, 2024

Antora site build successful! ✅
Deploying draft to GitHub Pages.
Deployment successful! View draft

Copy link
Contributor

@eric-schneider eric-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind, but I went ahead and pushed some formatting updates to the preview source directly to your branch. Feel free to modify them as you see fit.

As for the actual UI updates, I really like these changes! This provides a great solution for the majority of our current use-cases, and it's a great foundation for any future updates that we might want to make.

One minor concern: Any idea why my local gulp preview is missing the tab content outlines?

2024-02-07_15-05-19 (2)

@colegoldsmith
Copy link
Collaborator Author

Thanks for the content update! Super odd with those outlines, I'm not seeing it locally

@eric-schneider
Copy link
Contributor

Yeah, weird that we're seeing different things in the local gulp preview. I'm seeing it across browsers and across system restarts, so the issue is probably somewhere in the gulp stack on my machine.

@colegoldsmith colegoldsmith merged commit 5572682 into main Feb 8, 2024
@colegoldsmith colegoldsmith deleted the tabs-updates branch February 8, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tab title wrapping
3 participants