Add missing env feature to clap #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
flaub
approved these changes
Aug 19, 2024
SchmErik
pushed a commit
that referenced
this pull request
Aug 22, 2024
With #2196 we introduced the `env` usage in `clap` without adding the relative `env` feature to it. This result in having issues when building `cargo-risczero`, specifically when building it with only some of its features e.g.,: ```bash cargo build -p cargo-risczero --no-default-features --features "cuda" ``` or ```bash cargo build -p cargo-risczero --no-default-features --features "metal" ``` returns: ``` error[E0599]: no method named `env` found for struct `Arg` in the current scope --> risc0/cargo-risczero/src/commands/datasheet/mod.rs:41:38 | 41 | #[arg(long, value_name = "PATH", env = "RISC0_SERVER_PATH")] | ^^^ method not found in `Arg` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2196 we introduced the
envusage inclapwithout adding the relativeenvfeature to it. This result in having issues when buildingcargo-risczero, specifically when building it with only some of its features e.g.,:cargo build -p cargo-risczero --no-default-features --features "cuda"or
cargo build -p cargo-risczero --no-default-features --features "metal"returns: