fix(udb): fix postgres driver impl #3035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
baabddc to
7329d90
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
7329d90 to
570f2d3
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Closed
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| if self.committed.load(Ordering::SeqCst) { | ||
| return Ok(()); | ||
| } | ||
| self.committed.store(true, Ordering::SeqCst); |
There was a problem hiding this comment.
Consider moving the committed.store(true, Ordering::SeqCst) line after the successful commit operation to prevent a potential race condition. If the commit fails, the transaction would be incorrectly marked as committed, which could lead to unexpected behavior in error recovery scenarios.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
570f2d3 to
8e04f9c
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Oct 3, 2025
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
8e04f9c to
b9aa0d1
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
b9aa0d1 to
2d256a1
Compare
Closed
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
2d256a1 to
ea5bccd
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
NathanFlurry
approved these changes
Oct 8, 2025
Merge activity
|
NathanFlurry
force-pushed
the
10-01-fix_udb_fix_postgres_driver_impl
branch
from
ea5bccd to
60a09d5
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Comment on lines
+220
to
+272
| async fn handle_get_range( | ||
| &mut self, | ||
| tx: &Transaction<'_>, | ||
| begin_key: Vec<u8>, | ||
| begin_or_equal: bool, | ||
| begin_offset: i32, | ||
| end_key: Vec<u8>, | ||
| end_or_equal: bool, | ||
| end_offset: i32, | ||
| limit: Option<usize>, | ||
| reverse: bool, | ||
| ) -> Result<Values> { | ||
| // Determine SQL operators based on key selector types | ||
| // For begin selector: | ||
| // first_greater_or_equal: or_equal = false, offset = 1 -> ">=" | ||
| // first_greater_than: or_equal = true, offset = 1 -> ">" | ||
| let begin_op = if begin_offset == 1 { | ||
| if begin_or_equal { ">" } else { ">=" } | ||
| } else { | ||
| // This shouldn't happen for begin in range queries | ||
| ">=" | ||
| }; | ||
|
|
||
| // For end selector: | ||
| // first_greater_than: or_equal = true, offset = 1 -> "<=" | ||
| // first_greater_or_equal: or_equal = false, offset = 1 -> "<" | ||
| let end_op = if end_offset == 1 { | ||
| if end_or_equal { "<=" } else { "<" } | ||
| } else { | ||
| // This shouldn't happen for end in range queries | ||
| "<" | ||
| }; | ||
|
|
||
| // Build query with CTE that adds conflict range | ||
| let query = if reverse { | ||
| if let Some(limit) = limit { | ||
| format!( | ||
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC LIMIT {limit}" | ||
| ) | ||
| } else { | ||
| format!( | ||
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC" | ||
| ) | ||
| } | ||
| } else if let Some(limit) = limit { | ||
| format!( | ||
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key LIMIT {limit}" | ||
| ) | ||
| } else { | ||
| format!( | ||
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key" | ||
| ) | ||
| }; |
There was a problem hiding this comment.
The PostgreSQL implementation of handle_get_range doesn't add conflict ranges for read operations, unlike the RocksDB implementation. This inconsistency could lead to transaction anomalies when using serializable isolation. Consider adding code to insert conflict ranges for range reads, similar to how it's done in the RocksDB driver:
// Add read conflict range for this range
if let IsolationLevel::Serializable = isolation_level {
// Insert conflict range for the read operation
let query = "INSERT INTO conflict_ranges (range_data, conflict_type, start_version, commit_version)
VALUES (bytearange($1, $2, '[)'), 'read', $3, $4)";
// Execute with appropriate parameters
}This would ensure consistent behavior between database backends and proper serializable isolation semantics.
Suggested change
| async fn handle_get_range( | |
| &mut self, | |
| tx: &Transaction<'_>, | |
| begin_key: Vec<u8>, | |
| begin_or_equal: bool, | |
| begin_offset: i32, | |
| end_key: Vec<u8>, | |
| end_or_equal: bool, | |
| end_offset: i32, | |
| limit: Option<usize>, | |
| reverse: bool, | |
| ) -> Result<Values> { | |
| // Determine SQL operators based on key selector types | |
| // For begin selector: | |
| // first_greater_or_equal: or_equal = false, offset = 1 -> ">=" | |
| // first_greater_than: or_equal = true, offset = 1 -> ">" | |
| let begin_op = if begin_offset == 1 { | |
| if begin_or_equal { ">" } else { ">=" } | |
| } else { | |
| // This shouldn't happen for begin in range queries | |
| ">=" | |
| }; | |
| // For end selector: | |
| // first_greater_than: or_equal = true, offset = 1 -> "<=" | |
| // first_greater_or_equal: or_equal = false, offset = 1 -> "<" | |
| let end_op = if end_offset == 1 { | |
| if end_or_equal { "<=" } else { "<" } | |
| } else { | |
| // This shouldn't happen for end in range queries | |
| "<" | |
| }; | |
| // Build query with CTE that adds conflict range | |
| let query = if reverse { | |
| if let Some(limit) = limit { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC LIMIT {limit}" | |
| ) | |
| } else { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC" | |
| ) | |
| } | |
| } else if let Some(limit) = limit { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key LIMIT {limit}" | |
| ) | |
| } else { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key" | |
| ) | |
| }; | |
| async fn handle_get_range( | |
| &mut self, | |
| tx: &Transaction<'_>, | |
| begin_key: Vec<u8>, | |
| begin_or_equal: bool, | |
| begin_offset: i32, | |
| end_key: Vec<u8>, | |
| end_or_equal: bool, | |
| end_offset: i32, | |
| limit: Option<usize>, | |
| reverse: bool, | |
| ) -> Result<Values> { | |
| // Determine SQL operators based on key selector types | |
| // For begin selector: | |
| // first_greater_or_equal: or_equal = false, offset = 1 -> ">=" | |
| // first_greater_than: or_equal = true, offset = 1 -> ">" | |
| let begin_op = if begin_offset == 1 { | |
| if begin_or_equal { ">" } else { ">=" } | |
| } else { | |
| // This shouldn't happen for begin in range queries | |
| ">=" | |
| }; | |
| // For end selector: | |
| // first_greater_than: or_equal = true, offset = 1 -> "<=" | |
| // first_greater_or_equal: or_equal = false, offset = 1 -> "<" | |
| let end_op = if end_offset == 1 { | |
| if end_or_equal { "<=" } else { "<" } | |
| } else { | |
| // This shouldn't happen for end in range queries | |
| "<" | |
| }; | |
| // Add read conflict range for this range if using serializable isolation | |
| if let IsolationLevel::Serializable = self.isolation_level { | |
| let conflict_query = "INSERT INTO conflict_ranges (range_data, conflict_type, start_version, commit_version) | |
| VALUES (bytearange($1, $2, '[)'), 'read', $3, $4)"; | |
| tx.execute( | |
| conflict_query, | |
| &[&begin_key, &end_key, &self.start_version, &self.commit_version], | |
| ) | |
| .await | |
| .map_err(|e| Error::DatabaseError(e.to_string()))?; | |
| } | |
| // Build query with CTE that adds conflict range | |
| let query = if reverse { | |
| if let Some(limit) = limit { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC LIMIT {limit}" | |
| ) | |
| } else { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key DESC" | |
| ) | |
| } | |
| } else if let Some(limit) = limit { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key LIMIT {limit}" | |
| ) | |
| } else { | |
| format!( | |
| "SELECT key, value FROM kv WHERE key {begin_op} $1 AND key {end_op} $2 ORDER BY key" | |
| ) | |
| }; | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.