feat: freestyle deploy docs #3030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| }); | ||
| ``` | ||
|
|
||
| Its important to keep `timeout` set to `120`. Details on `buildDir` and other settings are available on [FreeStyle docs](https://docs.freestyle.sh/web/web). |
There was a problem hiding this comment.
There's a small grammatical error in this sentence - "Its important" should be "It's important" (with an apostrophe) since this is a contraction of "It is important".
| Its important to keep `timeout` set to `120`. Details on `buildDir` and other settings are available on [FreeStyle docs](https://docs.freestyle.sh/web/web). | |
| It's important to keep `timeout` set to `120`. Details on `buildDir` and other settings are available on [FreeStyle docs](https://docs.freestyle.sh/web/web). |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
d72a9e9 to
81ea72d
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
NathanFlurry
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
81ea72d to
1500ced
Compare
NathanFlurry
changed the base branch from
graphite-base/3030
to
10-05-chore_core_add_scripts_for_run_config
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
0f8ead9 to
b4422c4
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
| - `slotsPerRunner` - Concurrent actors per runner | ||
| - `requestLifespan` - Request timeout (slightly less than Freestyle timeout) | ||
|
|
||
| Once this configuration script is run, Rivet will be connect with your Freestyle serverless instance and you will be done! |
There was a problem hiding this comment.
There's a small grammatical error in this sentence. It should be "Rivet will be connected with your Freestyle serverless instance" rather than "Rivet will be connect with".
| Once this configuration script is run, Rivet will be connect with your Freestyle serverless instance and you will be done! | |
| Once this configuration script is run, Rivet will be connected with your Freestyle serverless instance and you will be done! |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
b4422c4 to
0bdb465
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
|
||
| // Freestyle uses Deno under the hood for web deployments | ||
| // @ts-ignore | ||
| Deno.serve(app.fetch); |
There was a problem hiding this comment.
The code references app.fetch, but there's no definition of an app variable in the provided code snippet. This should be updated to reference the correct object - likely registry.fetch based on the context, or another properly defined variable that provides the HTTP handler function for Deno's server.
| Deno.serve(app.fetch); | |
| Deno.serve(registry.fetch); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
| ```typescript | ||
| const FREESTYLE_DOMAIN = "my-domain.style.dev"; // Change to your desired Freestyle domain | ||
|
|
||
| const res = await freestyle.deployWeb(buildDir, { |
There was a problem hiding this comment.
It appears the freestyle object is being used without being defined or imported. Consider adding an import statement for the Freestyle SDK at the top of the file:
import { freestyle } from "@freestyle-sh/sdk";
// or however the SDK is properly importedThis will ensure the deployment code functions correctly when executed.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
0bdb465 to
789445b
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
789445b to
cf5b521
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
cf5b521 to
b81e378
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
abcxff
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
b81e378 to
021464b
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
force-pushed
the
10-01-feat_freestyle_deploy_docs
branch
from
021464b to
f5e17d2
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Fixes KIT-331