Skip to content

fix(core): fix underflow bug with desired slot count #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): fix underflow bug with desired slot count #3075

wants to merge 1 commit into from
+55 −11

Conversation

NathanFlurry
Copy link
Member

No description provided.

This was referenced Oct 5, 2025
Closed
Open
@NathanFlurry NathanFlurry mentioned this pull request Oct 5, 2025
Closed
@vercel Vercel
Copy link

vercel bot commented Oct 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ready Ready Preview Comment Oct 7, 2025 0:29am
rivet-inspector Ready Ready Preview Comment Oct 7, 2025 0:29am
rivet-site Ready Ready Preview Comment Oct 7, 2025 0:29am

@NathanFlurry NathanFlurry mentioned this pull request Oct 5, 2025
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Oct 5, 2025 •
edited by jog1t
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Oct 5, 2025
Open
@claude Claude
Copy link

claude bot commented Oct 5, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 5, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3075

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3075

commit: 45c1e9b

This was referenced Oct 5, 2025
Closed
Closed
@NathanFlurry NathanFlurry changed the base branch from 10-05-chore_core_update_docs to graphite-base/3075 October 6, 2025 15:22
@NathanFlurry NathanFlurry force-pushed the 10-05-fix_core_fix_underflow_bug_with_desired_slot_count branch from 60459e8 to 5f606d8 Compare October 6, 2025 16:26
@NathanFlurry NathanFlurry changed the base branch from graphite-base/3075 to 10-05-chore_core_add_api_helper_scripts October 6, 2025 16:26
@claude Claude
Copy link

claude bot commented Oct 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 10-05-chore_core_add_api_helper_scripts branch from 901bebb to 53534f4 Compare October 6, 2025 19:41
@NathanFlurry NathanFlurry force-pushed the 10-05-fix_core_fix_underflow_bug_with_desired_slot_count branch from 5f606d8 to a20af22 Compare October 6, 2025 19:41
@claude Claude
Copy link

claude bot commented Oct 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 6, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@MasterPtato MasterPtato mentioned this pull request Oct 7, 2025
Open
This was referenced Oct 7, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Oct 7, 2025 •
edited
Loading

Merge activity

  • Oct 7, 9:06 PM UTC: jog1t added this pull request to the Graphite merge queue.
  • Oct 7, 9:07 PM UTC: CI is running for this pull request on a draft pull request (#3099) due to your merge queue CI optimization settings.
  • Oct 7, 9:08 PM UTC: Merged by the Graphite merge queue via draft PR: #3099.

graphite-app bot pushed a commit that referenced this pull request Oct 7, 2025
@NathanFlurry
fix(core): fix underflow bug with desired slot count (#3075)
3d260c3
@graphite-app graphite-app bot closed this Oct 7, 2025
@graphite-app graphite-app bot deleted the 10-05-fix_core_fix_underflow_bug_with_desired_slot_count branch October 7, 2025 21:08
@MasterPtato MasterPtato mentioned this pull request Oct 7, 2025
Open
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Open
This was referenced Oct 7, 2025
Open
Open
Open
This was referenced Oct 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato