fix: remove frn #3106
Closed
fix: remove frn #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
commit: |
Graphite Automations"Test" took an action on this PR • (10/07/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
140e5fe to
dc1bc10
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
dc1bc10 to
bd2c76a
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
bd2c76a to
e9830a4
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
e9830a4 to
ed7cca1
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
NathanFlurry
approved these changes
Oct 8, 2025
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
ed7cca1 to
58093a8
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Oct 13, 2025
Closed
Closed
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
fa2b93b to
a3e4d24
Compare
jog1t
changed the base branch from
graphite-base/3106
to
10-13-chore_add_namespace_to_serverless_health_check_query
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This was referenced Oct 13, 2025
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Closed
This was referenced Oct 14, 2025
Closed
graphite-app
bot
changed the base branch from
10-13-chore_add_namespace_to_serverless_health_check_query
to
graphite-base/3106
jog1t
force-pushed
the
graphite-base/3106
branch
from
c507238 to
cf6d4d7
Compare
jog1t
force-pushed
the
10-08-fix_remove_frn
branch
from
a3e4d24 to
6ff51f5
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
### TL;DR Improved header handling in API clients by removing all Fern-related headers. ### What changed? - Modified the `cloud-data-provider.tsx` to use a more robust approach for removing Fern-related headers by iterating through all headers and removing any that start with "x-fern-" (case-insensitive) - Fixed a typo in the cloud provider where `fetcher` was called instead of `fetch` - Added the same header cleaning logic to the `engine-data-provider.tsx` to ensure consistent behavior across both data providers ### How to test? 1. Make API calls using both cloud and engine data providers 2. Verify that no "x-fern-" headers are being sent in the requests 3. Confirm that API calls complete successfully with the updated header handling ### Why make this change? The previous implementation in the cloud provider only removed specific Fern headers by name, which could miss other Fern headers. The new implementation ensures all Fern-related headers are removed systematically. Adding this same functionality to the engine provider ensures consistent behavior across both providers and prevents potential issues with unwanted headers being sent to the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved header handling in API clients by removing all Fern-related headers.
What changed?
cloud-data-provider.tsxto use a more robust approach for removing Fern-related headers by iterating through all headers and removing any that start with "x-fern-" (case-insensitive)fetcherwas called instead offetchengine-data-provider.tsxto ensure consistent behavior across both data providersHow to test?
Why make this change?
The previous implementation in the cloud provider only removed specific Fern headers by name, which could miss other Fern headers. The new implementation ensures all Fern-related headers are removed systematically. Adding this same functionality to the engine provider ensures consistent behavior across both providers and prevents potential issues with unwanted headers being sent to the API.