Skip to content

fix: buildQueryOptions error #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 10-08-fix_railway_connect_form
Choose a base branch
from
Open

fix: buildQueryOptions error #3132

wants to merge 1 commit into from

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Oct 8, 2025 •
edited
Loading

Closes FRONT-838

TL;DR

Hide the "Instances" section in the sidebar when the data provider doesn't support query options.

What changed?

Added a check to verify if the data provider has the buildsQueryOptions capability before rendering the "Instances" section in both the Subnav and CloudSidebarContent components. This prevents displaying the Instances section when it's not applicable.

How to test?

  1. Connect to a data provider that doesn't support query options
  2. Verify that the "Instances" section is not displayed in the sidebar
  3. Connect to a data provider that does support query options
  4. Verify that the "Instances" section appears correctly

Why make this change?

Some data providers don't support query options, making the "Instances" section irrelevant for those providers. This change improves the UI by only showing relevant navigation options based on the capabilities of the connected data provider.

@jog1t jog1t mentioned this pull request Oct 8, 2025
Open
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-inspector Ready Ready Preview Comment Oct 14, 2025 1:01am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Preview Oct 14, 2025 1:01am
rivet-site Ignored Ignored Preview Oct 14, 2025 1:01am

@jog1t jog1t mentioned this pull request Oct 8, 2025
Open
@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Oct 8, 2025 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude Claude
Copy link

claude bot commented Oct 8, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t marked this pull request as ready for review October 8, 2025 20:35
@linear Linear
Copy link

linear bot commented Oct 8, 2025

FRONT-838 Fix buildQueryOptions error

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 8, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner@3132

npm i https://pkg.pr.new/rivet-dev/engine/@rivetkit/engine-runner-protocol@3132

commit: 6d7b5f2

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Oct 8, 2025

Graphite Automations

"Test" took an action on this PR • (10/08/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

This was referenced Oct 8, 2025
Open
Open
Open
Open
Open
@jog1t jog1t force-pushed the 10-08-fix_railway_connect_form branch from c3abe3e to f784f10 Compare October 10, 2025 16:57
@jog1t jog1t force-pushed the 10-08-fix_buildqueryoptions_error branch from 8662f05 to dbd3c7a Compare October 10, 2025 16:57
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t mentioned this pull request Oct 10, 2025
Closed
@NathanFlurry NathanFlurry mentioned this pull request Oct 10, 2025
Closed
@jog1t jog1t force-pushed the 10-08-fix_railway_connect_form branch from f784f10 to 366f8f7 Compare October 10, 2025 23:07
@jog1t jog1t force-pushed the 10-08-fix_buildqueryoptions_error branch from dbd3c7a to d55922f Compare October 10, 2025 23:07
@claude Claude
Copy link

claude bot commented Oct 10, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@NathanFlurry NathanFlurry force-pushed the 10-08-fix_buildqueryoptions_error branch from a82585b to e0096df Compare October 12, 2025 21:21
@NathanFlurry NathanFlurry force-pushed the 10-08-fix_railway_connect_form branch from a7fc94f to 20b6f95 Compare October 12, 2025 21:21
@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 12, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t force-pushed the 10-08-fix_railway_connect_form branch from 20b6f95 to 17a4dbf Compare October 13, 2025 18:18
@jog1t jog1t force-pushed the 10-08-fix_buildqueryoptions_error branch from e0096df to 0ab7942 Compare October 13, 2025 18:18
@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

This was referenced Oct 13, 2025
Open
Open
Open
Open
@jog1t jog1t force-pushed the 10-08-fix_railway_connect_form branch from 17a4dbf to 2a323ff Compare October 13, 2025 23:44
@jog1t jog1t force-pushed the 10-08-fix_buildqueryoptions_error branch from 0ab7942 to 0d1d02f Compare October 13, 2025 23:44
This was referenced Oct 13, 2025
Closed
Closed
Open
@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@claude Claude
Copy link

claude bot commented Oct 13, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

@jog1t jog1t mentioned this pull request Oct 14, 2025
Open
@jog1t jog1t mentioned this pull request Oct 14, 2025
Open
@jog1t jog1t force-pushed the 10-08-fix_railway_connect_form branch from 2a323ff to dacdaef Compare October 14, 2025 00:52
@jog1t jog1t force-pushed the 10-08-fix_buildqueryoptions_error branch from 0d1d02f to 6d7b5f2 Compare October 14, 2025 00:52
@claude Claude
Copy link

claude bot commented Oct 14, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato Awaiting requested review from MasterPtato

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

Assignees

@jog1t jog1t

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jog1t