Skip to content

Commit 12ac484

Browse files
committed
fix(mm): broken cache (#806)
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
1 parent e789bf0 commit 12ac484

File tree

1 file changed

+28
-20
lines changed
  • svc/pkg/mm-config/ops/version-get/src

1 file changed

+28
-20
lines changed

svc/pkg/mm-config/ops/version-get/src/lib.rs

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -53,27 +53,35 @@ async fn handle(
5353
.map(common::Uuid::as_uuid)
5454
.collect::<Vec<_>>();
5555

56-
let versions = ctx
57-
.cache()
58-
.immutable()
59-
.fetch_all_proto("versions", req_version_ids, |mut cache, req_version_ids| {
60-
let ctx = ctx.base();
56+
let versions = fetch_versions(&ctx.base(), req_version_ids)
57+
.await?
58+
.into_iter()
59+
.map(|x| x.1)
60+
.collect::<Vec<_>>();
6161

62-
async move {
63-
fetch_versions(&ctx, req_version_ids)
64-
.await?
65-
.into_iter()
66-
.for_each(|(version_id, version)| {
67-
cache.resolve_with_topic(
68-
&version_id,
69-
version,
70-
("game_mm_versions", &version_id),
71-
)
72-
});
73-
Ok(cache)
74-
}
75-
})
76-
.await?;
62+
// TODO: There's a bug with this that returns the lobby groups for the wrong
63+
// version, can't figure this out
64+
// let versions = ctx
65+
// .cache()
66+
// .immutable()
67+
// .fetch_all_proto("versions", req_version_ids, |mut cache, req_version_ids| {
68+
// let ctx = ctx.base();
69+
//
70+
// async move {
71+
// fetch_versions(&ctx, req_version_ids)
72+
// .await?
73+
// .into_iter()
74+
// .for_each(|(version_id, version)| {
75+
// cache.resolve_with_topic(
76+
// &version_id,
77+
// version,
78+
// ("game_mm_versions", &version_id),
79+
// )
80+
// });
81+
// Ok(cache)
82+
// }
83+
// })
84+
// .await?;
7785

7886
Ok(mm_config::version_get::Response { versions })
7987
}

0 commit comments

Comments
 (0)