Fix bug with timezone which is not UTC #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gordonzhao
commented
Mar 11, 2016
gordonzhao
commented
- Add timezone to the Datetime creation
- Add timezone to the rfcExample test
- Add timezone to the Datetime creation - Add timezone to the rfcExample test
rlanvin
added a commit
that referenced
this pull request
Mar 11, 2016
Return results in the same timezone as DTSTART
|
Thank you! Just for clarification, the bug you fixed was not related to UTC. The results were returned in the default timezone configured in PHP, instead of the DTSTART timezone. It's also better to write a dedicated test for the bug - I did it for this pull request, just check commit 7e312ea if you want to see. |
|
You are right UTC is my default timezone. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.