Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rocon_python_comm] find_service returns wrong service list if unique=False #54

Closed
jihoonl opened this issue Jun 25, 2014 · 1 comment
Closed

[rocon_python_comm] find_service returns wrong service list if unique=False #54

jihoonl opened this issue Jun 25, 2014 · 1 comment
Assignees
@stonier
Labels
bug
Milestone
Indigo - Bugfix

Comments

@jihoonl
Copy link
Collaborator

jihoonl commented Jun 25, 2014

service_name parameters were used for two purpose, as interator while searching available services and as return variable when unique=True.

It caused problem when it searches for non unique service.
@jihoonl jihoonl added this to the Indigo - Bugfix milestone Jun 25, 2014
@jihoonl jihoonl added the bug label Jun 25, 2014
jihoonl added a commit that referenced this issue Jun 25, 2014
@jihoonl
to fix #54
e435960
@jihoonl
Copy link
Collaborator Author

jihoonl commented Jun 25, 2014

This issue is related robotics-in-concert/rocon_qt_gui#92

stonier added a commit that referenced this issue Jun 30, 2014
@stonier
Merge pull request #55 from robotics-in-concert/unique_service
b362594 
Bugfix service_name variable duplicate usage, #54.
@jihoonl jihoonl mentioned this issue Jun 30, 2014
Merged
@stonier stonier closed this as completed Jun 30, 2014
@stonier stonier self-assigned this Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonier stonier

Labels
bug
Projects
None yet
Milestone
Indigo - Bugfix
Development

No branches or pull requests
2 participants
@stonier @jihoonl