-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformating of Strategix and Cetautomatix nodes #39
Conversation
Start of reformating of cetautomatix and strategix
Available actions: both Phares & Pavillon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for the moment, I'll review it properly later. @mAxYoLo01 can continue his work this afternoon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice effort 👍
# "GOB38": {"COLOR": "GREEN", "IN_ECUEIL": True}, | ||
# "GOB40": {"COLOR": "GREEN", "IN_ECUEIL": True}, | ||
# "GOB43": {"COLOR": "GREEN", "IN_ECUEIL": True}, | ||
# } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?! 😂🆘
@@ -0,0 +1,14 @@ | |||
class Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a docstring to document that this is an abstract base class
super().__init__(position, **kwargs) | ||
self.step = 0 | ||
|
||
def get_initial_position(self, robot): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstring
position = (self.position[0] + offset, robot.width_param / 2 + 0.05) | ||
return position | ||
|
||
def start_actuator(self, robot): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
# elif self.bonPortGros.pos == 'Out' and self.bonPortPetit.pos == 'Good': | ||
# self.score += 5 | ||
# else: | ||
# self.score += 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again ?
# else: | ||
# offset = (0, 0.1) | ||
# elements[self._current_action]["Rot"] = 90 | ||
# self.drop = NC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
@@ -0,0 +1,505 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the file if you don't use it anymore. Git is there for you
* Add ceres-solver It's not available in debian buster aarch64
2b9eadd
to
4b68ac1
Compare
Continued translating old action positions to new object classes Few fixes & comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratz
Purpose
The goal of this PR is to reformat most of Cetautomatix and Strategix nodes, as they were poorly written in the previous year
Details of what has changed