-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External wrench smoothing feature for externalwrench gazebo yarp plugin #495
External wrench smoothing feature for externalwrench gazebo yarp plugin #495
Conversation
Can you make sure that all the commits corresponds to email associated to your GitHub account for the CLA? Thanks a lot! |
@prashanthr05 can you check if your review from #430 has been addressed? Thanks! |
Can you update the changelog: https://github.com/robotology/gazebo-yarp-plugins/blob/devel/CHANGELOG.md ? Thanks! |
I am trying to fix it. Any pointers to how to fix this ? |
I would rebase all the commits together, and then change the author with |
Given #430 (comment) may be @GiulioRomualdi is also interested in reviewing this PR |
Yes, it has been addressed. But in the previous review, I had not verified the math. However, it looks like the PR was tested and seems to have been working properly. I will go through the link added as documentation and cross-verify if required. Please let me know. |
I think it is ok to approve the PR @prashanthr05 even if you do not review the math in detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM. But it would be more appropriate to get approval from someone who has extensively tested this PR.
Some checks are failing due to robotology/robotology-superbuild#420 which is addressed in #496 |
Hi @Yeshasvitvs , let me know if you prefer to curate the commits, or if it is ok that I merge with squash. |
Please go ahead |
This is a similar PR as #430
It introduces the feature of smoothing the wrench when using externalwrench gazebo yarp plugin