Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model for iCubGenova11 #252

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add model for iCubGenova11 #252

merged 2 commits into from
Jan 11, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jan 9, 2024

The iCubGenova11 is an iCub 2.7, so we generated the model accordingly.

It also fixes #255 to ensure that CI is green. I manually run the CI to push the generated files in https://github.com/robotology/icub-models/tree/addicubgenova11 for testing @martinaxgloria .

@traversaro
Copy link
Member Author

This is required to use the "modern" wholebodydynamics device on iCubGenova11 . fyi @martinaxgloria

@traversaro
Copy link
Member Author

I manually run the CI to push the generated files in https://github.com/robotology/icub-models/tree/addicubgenova11 for testing @martinaxgloria .

The CI failed with:

fatal: Remote branch addicubgenova11 not found in upstream origin

I forgot that I add to create manually the branch in icub-models, we should document this somewhere. I relaunched the CI in https://github.com/robotology/icub-models-generator/actions/runs/7461748396 .

@martinaxgloria
Copy link
Collaborator

This is required to use the "modern" wholebodydynamics device on iCubGenova11 . fyi @martinaxgloria

Thank you very much @traversaro!

@traversaro
Copy link
Member Author

It took some back and forth, but now the test branch has the commit that adds iCubGenova11, see robotology/icub-models@bcbae74 . Probably some change in pip dependencies also did some spurious changes to the files, but the core change is the new file for iCubGenova11.

@traversaro
Copy link
Member Author

@martinaxgloria @Nicogene feel free to approve if you tested this!

@martinaxgloria
Copy link
Collaborator

@martinaxgloria @Nicogene feel free to approve if you tested this!

Hi @traversaro,
I'm going to test it today. Thanks!

@martinaxgloria
Copy link
Collaborator

I was thinking, since it is the model for iCubGenova11, which has the legs disabled (and also the FT on them), could we exclude them also in the urdf? Or they will be enabled again in the future on the real robot?

Or, better, there's a way with wholeBodyDynamics to choose which FT sensors are used (for example with a parameter)? In this way, there's no need to exclude the FT of the legs and the feet from the URDF

cc @Nicogene @traversaro

@martinaxgloria
Copy link
Collaborator

martinaxgloria commented Jan 10, 2024

According to this issue the only workaround so far is to modify the URDF. Then, I think we could disable at least the FT sensors of the lower body

@Nicogene
Copy link
Member

I was thinking, since it is the model for iCubGenova11, which has the legs disabled (and also the FT on them), could we exclude them also in the urdf? Or they will be enabled again in the future on the real robot?

Good point, since the legs are electrically disabled I would remove them, it will fall if used in gazebo but maybe we make it just fixed?

@traversaro
Copy link
Member Author

I was thinking, since it is the model for iCubGenova11, which has the legs disabled (and also the FT on them), could we exclude them also in the urdf? Or they will be enabled again in the future on the real robot?

Good point, since the legs are electrically disabled I would remove them, it will fall if used in gazebo but maybe we make it just fixed?

We are not generating any Gazebo-loadable model (i.e. with a model.config) out of this model, so I think we should be safe on this.

@traversaro
Copy link
Member Author

According to this issue the only workaround so far is to modify the URDF. Then, I think we could disable at least the FT sensors of the lower body

Good point. Could we think to add a Python script or similar that does this to the model generated by simmechanics (and eventually by creo2urdf)? I guess it should be a task that can be easily done with the help of ChatGPT or similar LLM tech.

@traversaro
Copy link
Member Author

According to this issue the only workaround so far is to modify the URDF. Then, I think we could disable at least the FT sensors of the lower body

Good point. Could we think to add a Python script or similar that does this to the model generated by simmechanics (and eventually by creo2urdf)? I guess it should be a task that can be easily done with the help of ChatGPT or similar LLM tech.

See https://chat.openai.com/share/69784828-87f9-4a53-b805-55d02d66384b for a starting point (I do not have time to work on this further), not sure if it works. Once we have that, I am happy to integrate the resulting Python script in CMake.

@Nicogene
Copy link
Member

According to this issue the only workaround so far is to modify the URDF. Then, I think we could disable at least the FT sensors of the lower body

Good point. Could we think to add a Python script or similar that does this to the model generated by simmechanics (and eventually by creo2urdf)? I guess it should be a task that can be easily done with the help of ChatGPT or similar LLM tech.

Ok for me!

@traversaro
Copy link
Member Author

@martinaxgloria @Nicogene Probably we can start merging this, and leave the disabling of the FT sensors in the future PR? In any case, this is for sure a net improvement over not having a model at all.

@Nicogene
Copy link
Member

@martinaxgloria @Nicogene Probably we can start merging this, and leave the disabling of the FT sensors in the future PR? In any case, this is for sure a net improvement over not having a model at all.

Ok for me!

@martinaxgloria
Copy link
Collaborator

Ok for me 👍

@traversaro traversaro merged commit 56e6eb8 into master Jan 11, 2024
3 of 4 checks passed
@traversaro traversaro deleted the addicubgenova11 branch January 11, 2024 09:14
@traversaro
Copy link
Member Author

I opened robotology/icub-models#229 for the follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodic CI failed January 2024
3 participants