-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model for iCubGenova11 #252
Conversation
This is required to use the "modern" |
The CI failed with:
I forgot that I add to create manually the branch in icub-models, we should document this somewhere. I relaunched the CI in https://github.com/robotology/icub-models-generator/actions/runs/7461748396 . |
Thank you very much @traversaro! |
It took some back and forth, but now the test branch has the commit that adds |
@martinaxgloria @Nicogene feel free to approve if you tested this! |
Hi @traversaro, |
I was thinking, since it is the model for iCubGenova11, which has the legs disabled (and also the FT on them), could we exclude them also in the urdf? Or they will be enabled again in the future on the real robot? Or, better, there's a way with wholeBodyDynamics to choose which FT sensors are used (for example with a parameter)? In this way, there's no need to exclude the FT of the legs and the feet from the URDF |
According to this issue the only workaround so far is to modify the URDF. Then, I think we could disable at least the FT sensors of the lower body |
Good point, since the legs are electrically disabled I would remove them, it will fall if used in gazebo but maybe we make it just fixed? |
We are not generating any Gazebo-loadable model (i.e. with a |
Good point. Could we think to add a Python script or similar that does this to the model generated by simmechanics (and eventually by creo2urdf)? I guess it should be a task that can be easily done with the help of ChatGPT or similar LLM tech. |
See https://chat.openai.com/share/69784828-87f9-4a53-b805-55d02d66384b for a starting point (I do not have time to work on this further), not sure if it works. Once we have that, I am happy to integrate the resulting Python script in CMake. |
Ok for me! |
@martinaxgloria @Nicogene Probably we can start merging this, and leave the disabling of the FT sensors in the future PR? In any case, this is for sure a net improvement over not having a model at all. |
Ok for me! |
Ok for me 👍 |
I opened robotology/icub-models#229 for the follow up. |
The
iCubGenova11
is an iCub 2.7, so we generated the model accordingly.It also fixes #255 to ensure that CI is green. I manually run the CI to push the generated files in https://github.com/robotology/icub-models/tree/addicubgenova11 for testing @martinaxgloria .