-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export joint limits #909
Export joint limits #909
Conversation
@priority-kew Do you mind adding a test checking for the limits in Note that this might imply you also need to expose |
The change seems nice, thanks, could you also update the CHANGELOG when you are done? In particular the support for exporting limits in the URDF ModelExporter could be useful also for user that do not use the pybind11 interface. |
Ok, I've added tests to python and made a new minor version in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
Co-authored-by: Silvio Traversaro <pegua1@gmail.com>
Gotcha, yeah I wasn't sure how releases worked. |
Seems good to go to me, what do you think @francesco-romano ? |
LGTM |
No description provided.