Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export joint limits #909

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Conversation

priority-kew
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021

CLA assistant check
All committers have signed the CLA.

@francesco-romano francesco-romano marked this pull request as ready for review July 28, 2021 08:38
@traversaro
Copy link
Member

The change seems nice, thanks, could you also update the CHANGELOG when you are done? In particular the support for exporting limits in the URDF ModelExporter could be useful also for user that do not use the pybind11 interface.

@priority-kew
Copy link
Contributor Author

Ok, I've added tests to python and made a new minor version in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

Co-authored-by: Silvio Traversaro <pegua1@gmail.com>
@priority-kew
Copy link
Contributor Author

Gotcha, yeah I wasn't sure how releases worked.

@traversaro
Copy link
Member

Seems good to go to me, what do you think @francesco-romano ?

@francesco-romano
Copy link
Collaborator

LGTM

@traversaro traversaro merged commit 6677914 into robotology:master Jul 30, 2021
@priority-kew priority-kew deleted the export_joint_limits branch July 30, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants