Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error when BufferManager is used without template and is member of a class #174

Closed
Nicogene opened this issue May 10, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Nicogene
Copy link
Member

I committed here a test that does not compile with this error:

/home/ngenesio/robotology/yarp-telemetry/test/BufferManagerTest.cpp:398:13: error: invalid use of template-name ‘robometry::BufferManager’ without an argument list
  398 |             robometry::BufferManager bm;
      |             ^~~~~~~~~
make[2]: *** [test/CMakeFiles/bufferManager_test.dir/build.make:76: test/CMakeFiles/bufferManager_test.dir/BufferManagerTest.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:586: test/CMakeFiles/bufferManager_test.dir/all] Error 2

With BufferManager<int> or BufferManager<> it compiles without problem.

Note that if it is not nested in a struct or class BufferManager bm; is a legit declaration:

robometry::BufferManager bm;

This issue affects also releases v0.5.0 and v0.5.1

cc @traversaro @GiulioRomualdi @S-Dafarra

@Nicogene
Copy link
Member Author

You can see the failure also in the CI: https://github.com/robotology/robometry/runs/6371615035?check_suite_focus=true

@S-Dafarra
Copy link
Collaborator

Since the change of name is already a breaking change, I would suggest removing the template parameter completely. It was initially needed to preserve backward compatibility, but I think that is gone anyway

@S-Dafarra
Copy link
Collaborator

S-Dafarra commented May 10, 2022

I am working on a PR: #175

@Nicogene
Copy link
Member Author

Fixed by #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants