Migrate from YARP_telemetry to robometry #155
Conversation
|
I am not sure if the changes in |
| yarp::telemetry::experimental::BufferConfig bufferConfig; | ||
| yarp::telemetry::experimental::BufferManager<double> bufferManager; | ||
| robometry::BufferConfig bufferConfig; | ||
| robometry::BufferManager<double> bufferManager; |
There was a problem hiding this comment.
I would suggest removing the template
There was a problem hiding this comment.
About this we are having this issue: robotology/robometry#174
There was a problem hiding this comment.
Accordingly to robotology/robometry#175 we should now be able to remove the template, am I right?
There was a problem hiding this comment.
Yes exactly, I removed it
|
Btw, it might be worth mentioning this modification in the |
I think that the CI will be broken until the new robometry packets will be released am I right @traversaro ? |
Yes |
|
Here 9caf780 I removed the installation of robometry in the CI for windows since the conda packages. This means that IWearLogger will be untested under windows until we have the packets |
I think it is a good idea. |
That's ok. We could open an issue after merging this PR in order to remember to add it back @Nicogene if the PR is ready I would proceed merging. |
.github/workflows/ci.yml
Outdated
| mamba install cmake compilers make ninja pkg-config | ||
| # Actual dependencies | ||
| mamba install -c robotology yarp wearables idyntree matio-cpp yarp-telemetry | ||
| mamba install -c robotology yarp wearables idyntree matio-cpp |
There was a problem hiding this comment.
Not related to this PR, but wearables should not be here
I opened the issue, I merge it! |
See robotology/robometry#173
Please review code.