Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osqp-matlab #585

Merged
merged 7 commits into from
Mar 23, 2021
Merged

Add osqp-matlab #585

merged 7 commits into from
Mar 23, 2021

Conversation

traversaro
Copy link
Member

Add support for compiling the osqp-matlab bindings if ROBOTOLOGY_ENABLE_DYNAMICS and ROBOTOLOGY_USES_MATLAB are enabled.

This PR is not ready to be merged as it depends on https://github.com/dic-iit/osqp-matlab-cmake-buildsystem/pull/1/files to be merged and the release v0.6.2.0 to be created, but it can be already reviewed.

Fix #575 .

@traversaro traversaro changed the title [WIP] Add osqp-matlab Add osqp-matlab Mar 11, 2021
cmake/Buildosqp-eigen.cmake Outdated Show resolved Hide resolved
cmake/Buildosqp-eigen.cmake Outdated Show resolved Hide resolved
cmake/Buildosqp-eigen.cmake Outdated Show resolved Hide resolved
@@ -183,3 +183,4 @@ repositories:
type: git
url: https://github.com/robotology/diagnostic-daemon.git
version: v1.0.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osqp-matlab disappeared after the merge from master. Was this intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The PR was opened before the 2021.02 release, but as the 2021.02 release has passed, it does not make sense to add a release for osqp-matlab here. Furthermore, we now have the latest releases file: #596 , so once osqp-matlab has a release we can add it there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I had seen that one. Great.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once osqp-matlab has a release we can add it there.

Do we do it in a new issue or we hold this PR until then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can review ami-iit/osqp-matlab-cmake-buildsystem#2 and then I will release a first version of osqp-matlab so that we can add its release here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I took a look at robotologyUpdateLatestReleases.sh and saw that in this line

yq -i eval ".repositories.${package_name}.version=\"${latest_tag}\"" ${latest_releases_yaml_file}

it assumes that the entry for the package exists, so if I understood it well, I guess we'll have to add it manually the first time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it assumes that the entry for the package exists, so if I understood it well, I guess we'll have to add it manually the first time.

Yes!

@traversaro
Copy link
Member Author

The latest.releases.yml file has been updated with the v0.6.2.0 release.

@traversaro traversaro merged commit b6fbe87 into master Mar 23, 2021
@traversaro traversaro deleted the add-osqp-matlab branch March 23, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add osqp-matlab bindings
2 participants