Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify install-miniforge to fully support zsh #839

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Modify install-miniforge to fully support zsh #839

merged 1 commit into from
Aug 3, 2021

Conversation

traversaro
Copy link
Member

No description provided.

@traversaro traversaro mentioned this pull request Jul 30, 2021
Open
@traversaro
Copy link
Member Author

Please ignore CI failures, they will be fixed by #840 and are unrelated.

@traversaro
Copy link
Member Author

Friendly ping @lrapetti @Giulero, if you are unable for lack of time to review the PR feel free to let me know. : )

@Giulero
Copy link

Giulero commented Aug 3, 2021

Sorry @traversaro! Looks good! I also followed the instructions and everything went well.
Thanks!

lrapetti
lrapetti approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@lrapetti lrapetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I had a look at the PR, and also tried to run the conda init zsh and the .zshrc seems to be updated correctly on MacOS

@traversaro traversaro merged commit 2555a82 into master Aug 3, 2021
@traversaro traversaro deleted the modify-miniforge-docs-zsh branch August 3, 2021 09:31
@traversaro
Copy link
Member Author

By the way, I had to manually mention conda init zsh in the README due to conda-forge/miniforge#127 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrapetti lrapetti lrapetti approved these changes

@Giulero Giulero Giulero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traversaro @Giulero @lrapetti