ergoCub - aligning XML - tentative nr.2 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
requested changes
Feb 3, 2023
pattacini
approved these changes
Feb 3, 2023
pattacini
requested changes
Feb 3, 2023
pattacini
approved these changes
Feb 3, 2023
| <param name="calibration1"> 38354 67734 6013 </param> | ||
| <!-- | ||
| <param name="calibration1"> 58233 8433 35531 </param> --> | ||
| <param name="calibration1"> 38354 1234 6551 </param> |
There was a problem hiding this comment.
@davidetome why these lines have been removed? I found those values during the torso's tests and they should be the right one. See the PR.
There was a problem hiding this comment.
Ok then, I'll patch devel straight away.
There was a problem hiding this comment.
@AntonioConsilvio please see df25353 and check if it's good.
There was a problem hiding this comment.
@AntonioConsilvio , I pushed the files that were in /usr/local/src/robot/robots-configuration where, as agreed, we did the changes to the robot files (not inside robotology-superbuild).
did you work there too?
There was a problem hiding this comment.
@AntonioConsilvio , as suggested by @pattacini , please check if they're correct 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title
cc @AntonioConsilvio