-
Notifications
You must be signed in to change notification settings - Fork 73
Update ergoCubSN002
conf files from robot fork
#755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…xx files when checking source/install diff
Done by Antonio, committed by Stefano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @pattacini, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the configuration files for the ergoCubSN002
robot, integrating recent changes from a robot-specific fork. The modifications encompass fine-tuning sensor and motor control parameters, adjusting the robot's whole-body dynamics model, and enhancing utility scripts for system management and diagnostics.
Highlights
- Calibration Updates: Updated calibration parameters for the left arm in
left_arm-calib.xml
. - Sensor Configuration Adjustments: Modified
ergocub.xml
,wholebodydynamics.xml
, andalljoints-inertials_remapper.xml
to comment out or remove references to right arm Force/Torque (FT) and Inertial Measurement Unit (IMU) sensors, streamlining the robot's sensor setup. - New Utility Commands: Added new shell aliases and functions in
additionalCommands.sh
for checking and restarting WiFi powersave settings, listing webcams, and setting YARP namespaces across multiple robot hosts. - Configuration File Checks: Updated
checkConfigurationFiles.sh
to exclude.onnx
files from configuration difference checks. - Hardware Connector Update: Adjusted the connector port assignment for the right hand's position sensor in
right_hand-pos2.xml
. - Electronics Logging Parameters: Introduced new
LOGGING
groups with parameters for immediate and periodic RX/TX activity statistics across numerous electronic board configuration files (head, arms, legs, torso). - Motor Control Parameter Tuning: Revised motor control parameters, including increasing
motorPwmLimit
and doubling PID gains (kp
,kd
,ki
,maxOutput
,maxInt
) for the head's motor inhead-eb20-j0_2-mc.xml
. - Actuator/Encoder Port Correction: Corrected and swapped port assignments for actuators and encoders in the left arm's motor control service file
left_arm-eb23-j7_10-mc_service.xml
. - RealSense Camera Configuration Enhancement: Added
extern-name
attributes to key parameters (depthResolution
,rgbResolution
,enableEmitter
) inrealsense.xml
for improved external naming.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various configuration files for ergoCubSN002
, including calibration values, hardware parameters, and utility scripts. The changes appear to synchronize configurations from a robot fork, disable right arm FT sensors, and add useful scripts and logging. My review focuses on improving the maintainability and robustness of the new scripts and XML configurations. I've identified opportunities to reduce code duplication, fix a potential bug in a shell script, and correct minor inconsistencies in formatting and naming.
As per title.