Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added weight retrieval function #56

Merged

Conversation

bemilio
Copy link
Contributor

@bemilio bemilio commented Mar 3, 2020

The TrajectoryGenerator is missing a method to get the weight in left and right feet that are instead present in the element . I added this functionality, copying it from the element

Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of small changes which are not "new". Can you try to remove all the small modifications and keep only those that you actually want to merge? Otherwise reviewing this PR is complicated.

As an example, you modified

iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of the unicycle and the point that has to be reach the goal. */

into

  iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of
                                                 the unicycle and the point that
                                                 has to be reach the goal. */

The problem is that this screws up the git diff.

@bemilio
Copy link
Contributor Author

bemilio commented Mar 4, 2020

There are a lot of small changes which are not "new". Can you try to remove all the small modifications and keep only those that you actually want to merge? Otherwise reviewing this PR is complicated.

As an example, you modified

iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of the unicycle and the point that has to be reach the goal. */

into

  iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of
                                                 the unicycle and the point that
                                                 has to be reach the goal. */

The problem is that this screws up the git diff.

Addressed

Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 😁

@S-Dafarra
Copy link
Collaborator

@GiulioRomualdi can we merge this?

@GiulioRomualdi
Copy link
Member

@bemilio before merging can you update the CHANGELOG.md file adding a line that summarizes the change that you added

@GiulioRomualdi GiulioRomualdi added the enhancement New feature or request label Mar 16, 2020
@bemilio
Copy link
Contributor Author

bemilio commented Mar 17, 2020

@bemilio before merging can you update the CHANGELOG.md file adding a line that summarizes the change that you added

Done

@GiulioRomualdi
Copy link
Member

Merging!

@GiulioRomualdi GiulioRomualdi merged commit 8992665 into robotology:devel Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants