-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added weight retrieval function #56
Added weight retrieval function #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of small changes which are not "new". Can you try to remove all the small modifications and keep only those that you actually want to merge? Otherwise reviewing this PR is complicated.
As an example, you modified
iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of the unicycle and the point that has to be reach the goal. */
into
iDynTree::Vector2 m_referencePointDistance; /**< Vector between the center of
the unicycle and the point that
has to be reach the goal. */
The problem is that this screws up the git diff.
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better 😁
@GiulioRomualdi can we merge this? |
@bemilio before merging can you update the |
Done |
Merging! |
The TrajectoryGenerator is missing a method to get the weight in left and right feet that are instead present in the element . I added this functionality, copying it from the element