Fixed some SonarQube issues

Author: robtimus

src/Robtimus/Obfuscation/Obfuscate.php

@@ -16,6 +16,7 @@ final class Obfuscate
 
     private function __construct()
     {
+        // private constructor to prevent initialization
     }
 
     /**
@@ -33,7 +34,7 @@ public static function all(string $mask = '*'): Obfuscator
             private string $_mask;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(string $mask)
+            public function __construct(string $mask)
             {
                 $this->_mask = $mask;
             }
@@ -103,7 +104,7 @@ public static function fixedValue(string $fixedValue): Obfuscator
             private string $_fixedValue;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(string $fixedValue)
+            public function __construct(string $fixedValue)
             {
                 $this->_fixedValue = $fixedValue;
             }

src/Robtimus/Obfuscation/Obfuscator.php

@@ -68,7 +68,7 @@ final public function untilLength(int $prefixLength): ObfuscatorPrefix
             private int $_prefixLength;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(Obfuscator $obfuscator, int $prefixLength)
+            public function __construct(Obfuscator $obfuscator, int $prefixLength)
             {
                 $this->_obfuscator = $obfuscator;
                 $this->_prefixLength = $prefixLength;
@@ -84,7 +84,7 @@ public function then(Obfuscator $other): Obfuscator
                     private Obfuscator $_second;
 
                     // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-                    function __construct(Obfuscator $first, int $lengthForFirst, Obfuscator $second)
+                    public function __construct(Obfuscator $first, int $lengthForFirst, Obfuscator $second)
                     {
                         parent::__construct($lengthForFirst + 1);
                         $this->_first = $first;

src/Robtimus/Obfuscation/PortionObfuscatorBuilder.php

@@ -184,7 +184,7 @@ public function build(): Obfuscator
             private string $_mask;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(int $keepAtStart, int $keepAtEnd, int $atLeastFromStart, int $atLeastFromEnd, int $fixedTotalLength, string $mask)
+            public function __construct(int $keepAtStart, int $keepAtEnd, int $atLeastFromStart, int $atLeastFromEnd, int $fixedTotalLength, string $mask)
             {
                 $this->_keepAtStart = $keepAtStart;
                 $this->_keepAtEnd = $keepAtEnd;

src/Robtimus/Obfuscation/PropertyObfuscator.php

@@ -224,7 +224,7 @@ public function build(): PropertyObfuscator
                      * @param array<string, array{ 'obfuscator': Obfuscator, 'forObjects': PropertyObfuscationMode, 'forArrays': PropertyObfuscationMode}> $caseSensitiveProperties
                      * @param array<string, array{'obfuscator': Obfuscator, 'forObjects': PropertyObfuscationMode, 'forArrays': PropertyObfuscationMode}>  $caseInsensitiveProperties
                      */
-                    function __construct(array $caseSensitiveProperties, array $caseInsensitiveProperties)
+                    public function __construct(array $caseSensitiveProperties, array $caseInsensitiveProperties)
                     {
                         $this->_caseSensitiveProperties = $caseSensitiveProperties;
                         $this->_caseInsensitiveProperties = $caseInsensitiveProperties;

src/Robtimus/Obfuscation/SplitPoint.php

@@ -100,7 +100,7 @@ final public function splitTo(Obfuscator $beforeSplitPoint, Obfuscator $afterSpl
             private Obfuscator $_afterSplitPoint;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(callable $splitStart, int $splitLength, Obfuscator $beforeSplitPoint, Obfuscator $afterSplitPoint)
+            public function __construct(callable $splitStart, int $splitLength, Obfuscator $beforeSplitPoint, Obfuscator $afterSplitPoint)
             {
                 $this->_splitStart = $splitStart;
                 $this->_splitLength  = $splitLength;
@@ -151,7 +151,7 @@ public static function atFirst(string $s): SplitPoint
             private int $_splitLength;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(string $splitAt)
+            public function __construct(string $splitAt)
             {
                 $this->_splitAt = $splitAt;
                 $this->_splitLength = mb_strlen($splitAt);
@@ -192,7 +192,7 @@ public static function atLast(string $s): SplitPoint
             private int $_splitLength;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(string $splitAt)
+            public function __construct(string $splitAt)
             {
                 $this->_splitAt = $splitAt;
                 $this->_splitLength = mb_strlen($splitAt);
@@ -238,7 +238,7 @@ public static function atNth(string $s, int $occurrence): SplitPoint
             private int $_splitLength;
 
             // phpcs:ignore PEAR.Commenting.FunctionComment.Missing
-            function __construct(string $splitAt, int $occurrence)
+            public function __construct(string $splitAt, int $occurrence)
             {
                 $this->_splitAt = $splitAt;
                 $this->_occurrence = $occurrence;

tests/Robtimus/Obfuscation/SplitPointTest.php

@@ -149,7 +149,7 @@ public static function zeroSplitLengthParameters(): array
         {
             private SplitPoint $_delegate;
 
-            function __construct()
+            public function __construct()
             {
                 $this->_delegate = SplitPoint::atFirst('@');
             }