-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version and date incorrectly reported re update info #1870
Comments
I am currently working on this issue and have fixed package version indication / retrieval and now looking at the change log element as this is, as per uncommitted changes, blank. |
A related component of this issue is that recent stable package releases appear to have incorrect dates within their changelog:
So the installed 3.9.2-3 and available package (3.9.2-4) are both down as having a changelog dated 6th November. Hence the yum changelog, which keys off of these dates returns nothing currently when fed with the otherwise correct:
where 2017-Dec-06 is derived from + 1 day of buildtime as retrieved by the now fixed in pending pr
The consequence of this is that even though there are changelogs available, although ver 3.9.2-4 has not been updated, they are not currently listed due to the above embedded date caveat within the rpm's themselves. Hard wiring the date var within system/pkg_mgmt.py/update_check() to for example '2017-Nov-01' (ie before our installed and now successfully retrieved builddate) proves we do parse successfully when the relevant dates are present within the rpm's themselves.
with the associated UI component for a system that has rockstor-3.9.2-3: ie we now have the up arrow, correct reporting of the installed version and, with the hard wired date to promote any change log at all, the same changelog as is presented at the command line. Obviously we also need to adapt change log entries within future packages to reflect the new hot-fix releases. |
A recent move to yum from rpm inadvertently caused a miss reporting of installed version for that of available version. This was due to the differing outputs and the inclusion of both installed and available in the newer yum format. The command switch set was revised to output only the installed version and to include the previously missing and required build date/time info. Consequent parsing adjustments were made to accommodate for the now changed date format. Time info was excluded as it is not used.
Pull request to follow shortly. |
…ctly_reported_re_update_info version and date incorrectly reported re update info. Fixes #1870
Note that if you are affected by this issue then the following command run as root should update your system
Please be patient for this command to end as there may be many packages to update. |
The indicated Rockstor package version can get 'confused' with the most recent version available. This leads to inaccuracies re user indicators based on installed package version/build date and the presence or otherwise of the 'up arrow' to indicate available updates. And given the package date is also set incorrectly (via a fail over) we are inadvertently displaying all known changes in our "List of changes in this update" rather than only those associated with the interim package versions.
The text was updated successfully, but these errors were encountered: