Fix unit tests and PHP8.1+ compatability #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from standard PHPUnit to yoast polyfill. - Setup sniff dependencies
Version 2 requires PHP7.4
`void` can't be used as a return type in PHP 7.0. The Yoast runner has helpers for this, so switching to those. See: https://github.com/Yoast/PHPUnit-Polyfills#testcases
v4 of the library introduced a few breaking changes. 1) GenerateErrorWrappr requries line to be an int 2) Rollbar\RollbarLogger:: log is now a wrapper around `report` that doesn't return the value that log used to return
Focus on the current stable WordPress, but still include upcoming WP
Add script for updating dependecies
|
You can see the passing unit tests at https://github.com/aaronjorbin/rollbar-php-wordpress/actions/runs/5512267190 |
|
The 2,021 files changed is due to
The actual files changed that should be reviewed are and a quick summary for each file:
|
|
Hi @aaronjorbin, thank you for the massive amount of work you have put into this! It will take me a little bit to review this, but I think this is heading in a good direction. |
danielmorell
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
@aaronjorbin Thank you for the work you have put into this. It looks really good! Sorry it took me a bit to go through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix #113 and #102
This updates the unit tests to use the Yoast Pollyfill and also wp-env for testing across multiple versions of PHP.
The underlying rollbar-php is both updated and kept the same. It's updated for sites running PHP8+, but kept the same for PHP7. This introduces a bit of technical debt as the actual dependencies aren't in the composer file but instead are in the
php7andphp8folder. To help manage that, a script is included for updating those dependencies.There are a few spots in the code that now also include PHP version specific code. When php7 support is dropped, these will need to be cleaned up.
Additionally, github actions are added in order to allow unit tests to run across multiple versions of PHP
Testing Instructions
If you want to test this change manually, you can use wp-env. clone the repo and make sure git, docker, and node are installed on your machine. Then run
npm installWP_ENV_PHP_VERSION="7.0" npm run wp-env start -- --updateto start with PHP 7.0You can login to Wordpress at http://localhost:8888/ with the username
adminand the passwordpasswordIf you want to test a different version of PHP, you can restart the env with a different PHP version passed in. For example,
WP_ENV_PHP_VERSION="8.2" npm run wp-env start -- --updateto start with PHP 8.2Type of change
Checklists
Development
Code review