feat!: rolldown native watcher (#329)

Author: sxzz

eslint.config.js

@@ -1,17 +1,23 @@
+// @ts-check
 import { sxzz } from '@sxzz/eslint-config'
 
-export default sxzz({
-  pnpm: true,
-})
-  .append({
+export default sxzz(
+  {
+    pnpm: true,
+    baseline: {
+      ignoreFeatures: ['explicit-resource-management'],
+    },
+  },
+  {
     files: ['templates/**'],
     rules: {
       'pnpm/json-enforce-catalog': 'off',
     },
-  })
-  .append({
+  },
+  {
     files: ['docs/**/*.md/**'],
     rules: {
       'unicorn/prefer-node-protocol': 'off',
     },
-  })
+  },
+)

package.json

@@ -91,7 +91,6 @@
   "dependencies": {
     "ansis": "catalog:prod",
     "cac": "catalog:prod",
-    "chokidar": "catalog:prod",
     "diff": "catalog:prod",
     "empathic": "catalog:prod",
     "hookable": "catalog:prod",

pnpm-lock.yaml

@@ -8,7 +8,7 @@ overrides:
 
 catalogs:
   dev:
-    '@sxzz/eslint-config': ^7.3.2
+    '@sxzz/eslint-config': ^7.4.0
     '@sxzz/prettier-config': ^2.2.6
     '@sxzz/test-utils': ^0.5.13
     '@types/node': ^24.10.1
@@ -49,7 +49,6 @@ catalogs:
     '@clack/prompts': ^0.11.0
     ansis: ^4.2.0
     cac: ^6.7.14
-    chokidar: ^5.0.0
     diff: ^8.0.2
     empathic: ^2.0.0
     giget: ^2.0.0

pnpm-workspace.yaml

@@ -52,10 +52,10 @@ export async function loadViteConfig(
 }
 
 const configPrefix = 'tsdown.config'
-let isWatch = false
+let noCacheLoad = false
 
-export function setWatch(): void {
-  isWatch = true
+export function setNoCacheLoad(): void {
+  noCacheLoad = true
 }
 
 export async function loadConfigFile(
@@ -110,7 +110,7 @@ export async function loadConfigFile(
     sources,
     cwd,
     stopAt: workspace && path.dirname(workspace),
-  }).load(isWatch)
+  }).load(noCacheLoad)
 
   let exported: UserConfigExport = []
   let file: string | undefined
@@ -146,7 +146,7 @@ type Parser = 'native' | 'unrun'
 function resolveConfigLoader(
   configLoader: InlineConfig['configLoader'] = 'auto',
 ): Parser {
-  if (isWatch) {
+  if (noCacheLoad) {
     return 'unrun'
   } else if (configLoader === 'auto') {
     const nativeTS = !!(

src/config/config.ts

@@ -331,48 +331,56 @@ async function resolveUserConfig(
 
   debug = resolveFeatureOption(debug, {})
   if (debug) {
-    debug.devtools ??= !!pkgExists('@vitejs/devtools/cli')
+    if (watch) {
+      if (debug.devtools) {
+        logger.warn('Devtools is not supported in watch mode, disabling it.')
+      }
+      debug.devtools = false
+    } else {
+      debug.devtools ??= !!pkgExists('@vitejs/devtools/cli')
+    }
   }
 
+  /// keep-sorted
   const config: ResolvedConfig = {
     ...userConfig,
+    alias,
+    attw,
+    cjsDefault,
+    clean,
+    copy: publicDir || copy,
+    cwd,
+    debug,
+    dts,
     entry,
-    plugins,
+    env,
+    exports,
+    external,
+    fixedExtension,
     format: normalizeFormat(format),
-    target,
-    outDir,
-    clean,
+    globImport,
+    hash,
+    ignoreWatch,
+    inlineOnly,
     logger,
-    treeshake,
+    name,
+    nodeProtocol,
+    noExternal,
+    outDir,
+    pkg,
     platform,
-    sourcemap,
-    dts,
+    plugins,
+    publint,
     report,
-    unused,
-    watch,
-    ignoreWatch,
     shims,
     skipNodeModulesBundle,
-    publint,
-    attw,
-    alias,
+    sourcemap,
+    target,
+    treeshake,
     tsconfig,
-    cwd,
-    env,
-    pkg,
-    copy: publicDir || copy,
-    hash,
-    name,
-    external,
-    noExternal,
-    exports,
     unbundle,
-    nodeProtocol,
-    cjsDefault,
-    globImport,
-    inlineOnly,
-    fixedExtension,
-    debug,
+    unused,
+    watch,
   }
 
   return config

src/config/index.ts

@@ -380,6 +380,9 @@ export interface UserConfig {
    * @default false
    */
   watch?: boolean | Arrayable<string>
+  /**
+   * Files or patterns to not watch while in watch mode.
+   */
   ignoreWatch?: Arrayable<string | RegExp>
 
   /**

src/config/types.ts

@@ -5,6 +5,7 @@ import { fsRemove } from '../utils/fs.ts'
 import { slash } from '../utils/general.ts'
 import { globalLogger } from '../utils/logger.ts'
 import type { ResolvedConfig, UserConfig } from '../config/index.ts'
+import type { OutputAsset, OutputChunk } from 'rolldown'
 
 const debug = createDebug('tsdown:clean')
 
@@ -64,3 +65,16 @@ export function resolveClean(
 
   return clean
 }
+
+export async function cleanupChunks(
+  outDir: string,
+  chunks: Array<OutputAsset | OutputChunk>,
+): Promise<void> {
+  await Promise.all(
+    chunks.map(async (chunk) => {
+      const filePath = path.resolve(outDir, chunk.fileName)
+      debug('Removing chunk file', filePath)
+      await fsRemove(filePath)
+    }),
+  )
+}

src/features/clean.ts

@@ -1,4 +1,7 @@
+import process from 'node:process'
 import { createHooks as create, type Hookable } from 'hookable'
+import { exec } from 'tinyexec'
+import treeKill from 'tree-kill'
 import type { ResolvedConfig } from '../config/index.ts'
 import type { BuildOptions } from 'rolldown'
 
@@ -49,3 +52,33 @@ export async function createHooks(options: ResolvedConfig): Promise<{
   }
   return { hooks, context }
 }
+
+export function executeOnSuccess(
+  config: ResolvedConfig,
+): AbortController | undefined {
+  if (!config.onSuccess) return
+
+  const ab = new AbortController()
+  if (typeof config.onSuccess === 'string') {
+    const p = exec(config.onSuccess, [], {
+      nodeOptions: {
+        shell: true,
+        stdio: 'inherit',
+      },
+    })
+    p.then(({ exitCode }) => {
+      if (exitCode) {
+        process.exitCode = exitCode
+      }
+    })
+    ab.signal.addEventListener('abort', () => {
+      if (typeof p.pid === 'number') {
+        treeKill(p.pid)
+      }
+    })
+  } else {
+    config.onSuccess(config, ab.signal)
+  }
+
+  return ab
+}